Skip to content

Bump geolocator to ^13.0.4 (replicates upstream #28) - #3

Merged
iamEtornam merged 1 commit into
mainfrom
upstream-pr-28-geolocator-13
Jul 8, 2026
Merged

Bump geolocator to ^13.0.4 (replicates upstream #28)#3
iamEtornam merged 1 commit into
mainfrom
upstream-pr-28-geolocator-13

Conversation

@iamEtornam

Copy link
Copy Markdown
Owner

Replicates upstream PR hlefe#28 by @Zweycinder.

Change: pubspec.yaml dependency geolocator bumped from ^12.0.0 to ^13.0.4.

Original author: Zweycinder. Upstream PR: hlefe#28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the geolocator dependency in pubspec.yaml from version ^12.0.0 to ^13.0.4. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@iamEtornam

Copy link
Copy Markdown
Owner Author

Review — VERDICT: ✅ LGTM

Replicates upstream hlefe#28 (geolocator ^12.0.0^13.0.4). Verified: pub get resolves cleanly, flutter analyze lib test = 0 errors.

  • No broken API. geolocator usage in ar_location_manager.dart (isLocationServiceEnabled, checkPermission, requestPermission, getLastKnownPosition, getPositionStream(locationSettings:), openAppSettings, openLocationSettings, getCurrentPosition()) is all stable across v12→v13.
  • ✅ The v13 breaking change (removal of deprecated desiredAccuracy on getCurrentPosition) doesn't apply — it's called with no args — and the position stream already uses the new LocationSettings API. Empirically confirmed by the clean analyzer run.
  • 🔸 Note: geolocator 13 raises platform minimums (newer Android compile/Gradle & iOS deployment target). A host-app integration concern, not a code break.

Safe to merge.

@iamEtornam
iamEtornam merged commit 54f8ddb into main Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants