Android build.gradle: ARCore dep + SDK/Kotlin bumps (replicates upstream #33) - #5
Merged
Merged
Conversation
Added google AR implementation in dependencies with this line of code. implementation 'com.google.ar:core:1.43.0'
packagingOptions {
jniLibs {
useLegacyPackaging = false
}
}
Update Kotlin version to 1.9.22 from 1.9.10
Removed from buildscript dependencies and added in dependencies section: implementation 'com.google.ar:core:1.43.0'
Updated the code in build.gradle
Upgrade compileSdk and targetSdk to version 34 to 36
Update ARCore dependency version to 1.52.0 from 1.43.0
Updated compileSdk and targetSdk versions to 34 and removed unnecessary buildscript and repositories sections.
Upgrade compileSdk and targetSdk to version 36 and kotlin version to 2.1.10
Owner
Author
Review — VERDICT:
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicates upstream PR hlefe#33 by @navakanth.
Change (net of 9 commits): rewrites
android/build.gradle— removes thebuildscript/allprojectsblocks, addscom.google.ar:core:1.52.0, bumpscompileSdk/targetSdkto 36 andkotlin-stdlibto 2.1.10, addspackagingOptions { jniLibs { useLegacyPackaging = false } }.androidx.constraintlayout:constraintlayout(used by the hand-motion guide layout) and removes the AGP classpath while raising compileSdk to 36 — this may break the build. Flagged for review.Original author: navakanth. Upstream PR: hlefe#33