[patch] improve ignored secret fields - #515
Draft
boonware wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
MASAIB-2602
Description
Ensure that the AI Service tenant SLS secret fields are only ignored by ArgoCD if they were added by an application that is not ArgoCD itself. Currently, the tenant operator adds some fields which should be ignored, but fields initially created by ArgoCD should not and these should trigger a sync if changed in the source (Secrets Manager). Both the current name and the future "ibm-aiservice-tenant-operator" name that will be used in the next operator patch release are added.
Test Results
TODO