[patch] Update PR validation to verify all _cli_image_digest values are the same - #516
Merged
Conversation
Deliberately permitting commits where only a single digest has been updated to reduce friction when devs want to quickly update a single Job for testing
tomklapiscak
changed the title
mnivedithaa
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_cli_image_digestbeing updated in a single file without being changed in all files is a recurring pain point - especially in airgapped envs where not all CLI image releases are available.This PR prevents this issue from happening again by failing PR checks if a developer attempts to update one
_cli_image_digestvalue without updating all of the others (i.e. using the providedset-cli-image-digest.shscript).Based on feedback from the SaaS squad, this check has been deliberately omitted from pre-commit hooks - this is to reduce friction by allowing devs to quickly test a single Job update in isolation during the development process.