Add Ultra performance level for throttle-avoidance cooling#7
Draft
nsd97 wants to merge 4 commits into
Draft
Conversation
Introduce PreviewSupport fixtures (no SMC/XPC in canvas), #Preview on every View, and a ChillMacTests target so previews and fixture contracts stay verifiable. Co-authored-by: Cursor <cursoragent@cursor.com>
Register the helper with BundleProgram and LaunchDaemons layout, gate Performance Mode on a live helper with an Install CTA, and extract testable PerformanceCurve/FanControlPolicy helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid @published dictionary churn that invalidates the popover mid-update when Performance Mode re-sends the same target. Co-authored-by: Cursor <cursoragent@cursor.com>
Introduce a fifth Performance Mode curve with a higher floor and earlier ramp to 100%, plus docs, preview, and curve tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a fifth Performance Mode level — Ultra — a louder/earlier temperature-responsive curve (higher floor, full speed by ~60°C) so fans cool sooner under load without constant 100% blast.
Context
mainafter Fix SMAppService helper so Performance Mode can control fans #6 merges. This branch currently includes Add Swift Testing harness and SwiftUI previews #5+Fix SMAppService helper so Performance Mode can control fans #6 commits.What changed
PerformanceLevel.ultra+ Ultra branch ofPerformanceCurve(70% floor, 100% by ~60°C, faster ramps than Max)release-notes/v1.8.0.mdMax vs Ultra (short)
Review guide
Start at:
ChillMac/App/AppSettings.swift(PerformanceLevel) →ChillMac/Fan/PerformanceCurve.swift(.ultra) →ChillMacTests/Unit/Fan/PerformanceCurveTests.swiftHow to test
xcodegen generate && xcodebuild -project ChillMac.xcodeproj -scheme ChillMac -destination 'platform=macOS' testChecklist
xcodegen generate && xcodebuild -scheme ChillMac build)xcodebuild -project ChillMac.xcodeproj -scheme ChillMac -destination 'platform=macOS' test)Made with Cursor