CROSSLINK-295 Add batch action defaults to state model configuration#652
Open
JanisSaldabols wants to merge 2 commits into
Open
CROSSLINK-295 Add batch action defaults to state model configuration#652JanisSaldabols wants to merge 2 commits into
JanisSaldabols wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a consolidated built-in state model configuration file and exposes built-in “batch action default” templates via a new API endpoint, alongside the OpenAPI and module-permission wiring needed to surface that endpoint.
Changes:
- Replace per-model embedded JSON loading with a single embedded
state-models.jsoncontaining named state models. - Add
batchActionDefaultsto the state model configuration and expose them viaGET /state_model/batch_actions. - Update OpenAPI and the module descriptor to include the new route and required permissions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| broker/patron_request/service/statemodels/state-models.json | Adds consolidated state model config and introduces batch action default templates. |
| broker/patron_request/service/statemodels/returnables.json | Removes the standalone returnables model JSON (now embedded via consolidated config). |
| broker/patron_request/service/statemodel.go | Switches embedded loading to a single config file; adds accessors for batch action defaults. |
| broker/patron_request/api/api-handler.go | Adds handler to return built-in batch action defaults. |
| broker/oapi/open-api.yaml | Defines GET /state_model/batch_actions response schema. |
| broker/descriptors/ModuleDescriptor-template.json | Adds permissions/routes for state model capabilities + batch action defaults endpoints. |
Comment on lines
+115
to
+117
| func (a *PatronRequestApiHandler) GetStateModelBatchActions(w http.ResponseWriter, r *http.Request, params proapi.GetStateModelBatchActionsParams) { | ||
| api.WriteJsonResponse(w, prservice.GetStateModelBatchActionDefaults()) | ||
| } |
JanisSaldabols
force-pushed
the
CROSSLINK-295
branch
from
d69f8d9 to
6e7467d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.