Consolidate InOrbit URL env vars#96
Merged
Merged
Conversation
INORBIT_API_URL meant the configuration endpoint in models but the REST API in the demo example and downstream executor. Shared env vars across the Connect SDK stack were unusable. Establish new names: - INORBIT_CONFIG_URL: configuration endpoint (was INORBIT_API_URL in models, INORBIT_URL in demo) - INORBIT_API_URL: REST API endpoint (was INORBIT_REST_API_URL in models) Old names removed with no fallback (breaking). Module constant INORBIT_REST_API_URL renamed to INORBIT_DEFAULT_REST_API_URL to disambiguate from the env var. Exported INORBIT_CLOUD_SDK_ROBOT_CONFIG_URL preserved (imported by connector-python). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
I think the name |
Member
Author
|
@miguelgarcia |
Member
Author
|
@miguelgarcia ready for another look |
miguelgarcia
approved these changes
May 26, 2026
b-Tomas
added a commit
that referenced
this pull request
May 27, 2026
* Consolidate InOrbit URL env vars INORBIT_API_URL meant the configuration endpoint in models but the REST API in the demo example and downstream executor. Shared env vars across the Connect SDK stack were unusable. Establish new names: - INORBIT_CONFIG_URL: configuration endpoint (was INORBIT_API_URL in models, INORBIT_URL in demo) - INORBIT_API_URL: REST API endpoint (was INORBIT_REST_API_URL in models) Old names removed with no fallback (breaking). Module constant INORBIT_REST_API_URL renamed to INORBIT_DEFAULT_REST_API_URL to disambiguate from the env var. Exported INORBIT_CLOUD_SDK_ROBOT_CONFIG_URL preserved (imported by connector-python). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Rename INORBIT_CONFIG_URL -> INORBIT_CONNECTION_CONFIG_URL * Fix linter --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 27, 2026
b-Tomas
added a commit
to inorbit-ai/inorbit_edge_executor
that referenced
this pull request
May 27, 2026
Rename INORBIT_API_BASE_URL to INORBIT_API_URL in the example, aligning with the canonical env var names established in inorbit-ai/edge-sdk-python#96. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
b-Tomas
added a commit
to inorbit-ai/inorbit-connector-python
that referenced
this pull request
May 28, 2026
…ables (#77) * Consolidate InOrbit environment variables Align connector-python with edge-sdk v3 env var consolidation (inorbit-ai/edge-sdk-python#96). The config endpoint and REST API now have unambiguous, non-colliding env var names across the stack. - Rename `api_url` field to `connection_config_url` (reads `INORBIT_CONNECTION_CONFIG_URL`) - Add new `api_url` field for the REST API (reads `INORBIT_API_URL`, defaults to `https://api.inorbit.ai`) - Remove manual `os.environ.get("INORBIT_REST_API_URL", …)` from connector.py — REST API URL now flows through config like every other setting - Bump `inorbit-edge` dependency to `>=3.0,<4.0` - Update env files, docs, and tests BREAKING CHANGE: `INORBIT_API_URL` no longer sets the config endpoint — it now sets the REST API URL. Use `INORBIT_CONNECTION_CONFIG_URL` for the config endpoint. The Python field `api_url` on `ConnectorRootConfig` is renamed to `connection_config_url`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove account_id references --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
b-Tomas
added a commit
to inorbit-ai/inorbit-connector-python
that referenced
this pull request
May 28, 2026
…ables (#77) * Consolidate InOrbit environment variables Align connector-python with edge-sdk v3 env var consolidation (inorbit-ai/edge-sdk-python#96). The config endpoint and REST API now have unambiguous, non-colliding env var names across the stack. - Rename `api_url` field to `connection_config_url` (reads `INORBIT_CONNECTION_CONFIG_URL`) - Add new `api_url` field for the REST API (reads `INORBIT_API_URL`, defaults to `https://api.inorbit.ai`) - Remove manual `os.environ.get("INORBIT_REST_API_URL", …)` from connector.py — REST API URL now flows through config like every other setting - Bump `inorbit-edge` dependency to `>=3.0,<4.0` - Update env files, docs, and tests BREAKING CHANGE: `INORBIT_API_URL` no longer sets the config endpoint — it now sets the REST API URL. Use `INORBIT_CONNECTION_CONFIG_URL` for the config endpoint. The Python field `api_url` on `ConnectorRootConfig` is renamed to `connection_config_url`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove account_id references --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
edge-sdk-pythonreads two distinct InOrbit endpoints, a robot configuration endpoint and a REST API, but the env vars naming them collide and duplicate.INORBIT_API_URLmeans the configuration endpoint ininorbit_edge/models.pybut the REST API in the demo example; the REST API also goes byINORBIT_REST_API_URLin the model. The same ambiguity repeats inconnector-pythonandedge-executor, so a shared.envcannot serve the full Connect SDK stack.This PR picks one name per endpoint. Updates to
connector-pythonandedge-executor) follow.Before
INORBIT_API_URLinorbit_edge/models.pyendpointINORBIT_REST_API_URLinorbit_edge/models.pyrest_api_endpointINORBIT_URLtests/demo/example.pyendpointINORBIT_API_URLtests/demo/example.pyrest_api_endpointAfter
INORBIT_CONNECTION_CONFIG_URLendpointhttps://control.inorbit.ai/cloud_sdk_robot_configINORBIT_API_URLrest_api_endpointhttps://api.inorbit.aiINORBIT_API_URLis reused but its meaning inmodels.pyflips from configuration to REST API.Changes
inorbit_edge/models.py:endpointreadsINORBIT_CONNECTION_CONFIG_URL;rest_api_endpointreadsINORBIT_API_URL. Old names not recognized (no fallback).inorbit_edge/robot.py: module-level default constant renamed fromINORBIT_REST_API_URLtoINORBIT_DEFAULT_API_URLso it no longer collides with the env var. ExportedINORBIT_CLOUD_SDK_ROBOT_CONFIG_URLpreserved (connector-pythonimports it).inorbit_edge/tests/demo/example.pyandREADME.md: updated.inorbit_edge/tests/test_robot_session.py: import updated.Migration
INORBIT_URLtoINORBIT_CONNECTION_CONFIG_URL.INORBIT_API_URLfor the configuration endpoint (matching previousmodels.pybehavior), rename it toINORBIT_CONNECTION_CONFIG_URL.INORBIT_API_URLis now exclusively the REST API.inorbit_edge.robot.INORBIT_REST_API_URLmust switch toINORBIT_DEFAULT_API_URL.Follow-ups
connector-python: mirror the env var rename; addINORBIT_API_URLtorest_api_endpointpassthrough (currently no env-var way to set the REST endpoint).edge-executor: replaceINORBIT_URLandINORBIT_API_BASE_URLwith the new names.