Remove deprecated APIs ahead of v3#98
Merged
Merged
Conversation
Remove `with_counter_metric_async()` (deprecated in v2.0.2) and `RobotSessionPool.register_command_callback()` (deprecated in v1.7.2). Both had zero production callers. Also removes the `deprecated` package dependency since no other code imports it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes two previously deprecated public APIs in preparation for the upcoming v3 major release, and cleans up the associated dependency now that deprecation decorators are no longer used.
Changes:
- Removed
with_counter_metric_async()frominorbit_edge.metrics(deprecated in v2.0.2) in favor ofwith_counter_metric()which already auto-detects async functions. - Removed
RobotSessionPool.register_command_callback()frominorbit_edge.robot(deprecated in v1.7.2) in favor ofRobotSessionFactory.register_command_callback(). - Dropped the
deprecateddependency fromrequirements.txtand removed the corresponding deprecation-warning test.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| requirements.txt | Removes the now-unused deprecated runtime dependency. |
| inorbit_edge/metrics.py | Removes the deprecated with_counter_metric_async() alias and deprecated import. |
| inorbit_edge/robot.py | Removes the deprecated RobotSessionPool.register_command_callback() method and deprecated import. |
| inorbit_edge/tests/test_metrics.py | Removes the deprecation-warning test and the unused warnings import. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
miguelgarcia
approved these changes
May 26, 2026
b-Tomas
added a commit
that referenced
this pull request
May 27, 2026
Remove `with_counter_metric_async()` (deprecated in v2.0.2) and `RobotSessionPool.register_command_callback()` (deprecated in v1.7.2). Both had zero production callers. Also removes the `deprecated` package dependency since no other code imports it. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Description
Remove two deprecated APIs ahead of the v3 major version bump:
with_counter_metric_async()(deprecated v2.0.2) -- replaced bywith_counter_metric()which auto-detects async functionsRobotSessionPool.register_command_callback()(deprecated v1.7.2) -- replaced byRobotSessionFactory.register_command_callback()Also removes the
deprecatedpackage fromrequirements.txtsince it is not used anymore.Files changed:
inorbit_edge/metrics.py-- removed function + importinorbit_edge/robot.py-- removed method + importinorbit_edge/tests/test_metrics.py-- removed deprecation warning test + unused importrequirements.txt-- removeddeprecateddependency