Skip to content

fbgemm-xpu: add CI workflow - #86

Merged
dvrogozh merged 21 commits into
intel:mainfrom
aagalleg:flezaalv/feat/add-ci-fbgemm-xpu
Jul 27, 2026
Merged

fbgemm-xpu: add CI workflow#86
dvrogozh merged 21 commits into
intel:mainfrom
aagalleg:flezaalv/feat/add-ci-fbgemm-xpu

Conversation

@flezaalv

@flezaalv flezaalv commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@flezaalv flezaalv changed the title ci: add fbgemm-xpu build/test/publish workflow fbgemm-xpu: add CI workflow Jul 3, 2026
@dvrogozh

Copy link
Copy Markdown
Contributor

There are couple attempts to break current CI workflow into dedicated torchcodec and fbgemm parts (#86 and #88). Unfortunately we will have some issues with this approach centered around the fact that we have one more package to take care about - torchlib-xpu which is a virtual package depending on other. If you will think thru that you will see that it's not quite trivial to satisfy all the requirements at once such as aligned pytorch version to use across the whole project and having CI in separate workflows for each project.

Overall, I suggest a little bit different strategy. I think we should not break current monolithic CI workflow. I believe that it's better to have single pass to build all the components - this part is cheap enough and 90% the same across both projects. What we need to do is to optimize test time. For that I suggest to add skips of the test jobs depending on the modified paths. Here is respective PR, please, take a look:

@flezaalv , can you, please, modify the PR building on top of #93?

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@flezaalv

Copy link
Copy Markdown
Contributor Author

There are couple attempts to break current CI workflow into dedicated torchcodec and fbgemm parts (#86 and #88). Unfortunately we will have some issues with this approach centered around the fact that we have one more package to take care about - torchlib-xpu which is a virtual package depending on other. If you will think thru that you will see that it's not quite trivial to satisfy all the requirements at once such as aligned pytorch version to use across the whole project and having CI in separate workflows for each project.

Overall, I suggest a little bit different strategy. I think we should not break current monolithic CI workflow. I believe that it's better to have single pass to build all the components - this part is cheap enough and 90% the same across both projects. What we need to do is to optimize test time. For that I suggest to add skips of the test jobs depending on the modified paths. Here is respective PR, please, take a look:

@flezaalv , can you, please, modify the PR building on top of #93?

I will do

@dvrogozh dvrogozh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase the

Comment thread packages/fbgemm-xpu/README.md Outdated
Comment thread .github/workflows/ci.yml Outdated
flezaalv added 13 commits July 23, 2026 23:14
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
… triggers

Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
@flezaalv
flezaalv force-pushed the flezaalv/feat/add-ci-fbgemm-xpu branch from 4956d82 to 606c4a8 Compare July 23, 2026 23:15
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>

@dvrogozh dvrogozh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you, please, move packages/fbgemm-xpu/test/patches/.gitkeep‎ to packages/fbgemm-xpu/patches/.gitkeep‎? This will correlate with the placement of the patches for torchcodec.

Comment thread packages/fbgemm-xpu/pyproject.toml Outdated
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
@flezaalv

Copy link
Copy Markdown
Contributor Author

Can you, please, move packages/fbgemm-xpu/test/patches/.gitkeep‎ to packages/fbgemm-xpu/patches/.gitkeep‎? This will correlate with the placement of the patches for torchcodec.

Done.

flezaalv added 3 commits July 24, 2026 18:24
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>
Signed-off-by: Felipe Leza Alvarez <felipe.leza.alvarez@intel.com>

@dvrogozh dvrogozh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flezaalv , I think this PR is almost ready. Please, take a look and reply at last couple comments and mark as ready for review.

Comment thread .github/workflows/ci.yml Outdated
@dvrogozh
dvrogozh marked this pull request as ready for review July 27, 2026 22:02
dvrogozh
dvrogozh previously approved these changes Jul 27, 2026

@dvrogozh dvrogozh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luis-real
luis-real previously approved these changes Jul 27, 2026

@luis-real luis-real left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/ci.yml Outdated
Co-authored-by: Alberto <109159606+aagalleg@users.noreply.github.com>
@dvrogozh
dvrogozh dismissed stale reviews from luis-real and themself via 936fa1b July 27, 2026 22:12

@aagalleg aagalleg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvrogozh
dvrogozh merged commit 91873dc into intel:main Jul 27, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants