Fix the Release workflow and restore the pending 0.4.0 changesets#141
Conversation
This reverts commit 92b9455.
The changesets action commits 'Version Packages' via git-cli on the runner, which fires the husky pre-commit hook. The hook's test suite needs a built leadtype dist (the repo-docs lint test typechecks snippets against the package), and the Release job never builds one, so every Release run since snippet typechecking landed has failed inside the hook — leaving the Version Packages PR stale and blocking publish. CI already builds and runs the full suite on the PR, so set HUSKY=0 on the changesets step.
|
This run was cancelled 🛑 The workflow was cancelled before completion. Please check the link below for details. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (18)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1 participant
Problem
Every Release run on main has failed since #137. The changesets action commits "Version Packages" via git-cli on the runner, which fires the husky pre-commit hook, whose test suite includes
leadtype CLI > runs lint against this repo's docs. Since #137 that lint typechecks the repo docs' snippets against the built package — and the Release job never buildsdist/(CI does, via its explicit Build leadtype + Link CLI steps), so the test fails on the runner and the hook aborts the action's commit.Because of that, the Version Packages PR (#104) was never updated with the changesets from #138/#139/#140 — and it was merged stale. Current state of main before this PR:
package.jsonsays 0.4.0, but npm is still at 0.3.1 — the publish never ran, and there is noleadtype@0.4.0tag.lint-external-links,mdx-children-registry,mcp-card-polish), which are still pending on main — so the next successful version run would incorrectly open a 0.5.0 PR.Fix
HUSKY: "0"on the changesets step — skip git hooks for the action's commit. The hook's suite is redundant there: CI builds and runs everything on the PR itself.Version Packagescommit (92b9455) — safe because nothing was published or tagged. This restores 0.3.1 and all 19 changesets, so on merge the fixed workflow regenerates a complete Version Packages PR: a proper 0.4.0 containing every changeset.After merging
The Release workflow will open a fresh "Version Packages" PR for 0.4.0. Merging that one publishes to npm and bumps the homebrew tap.
🤖 Generated with Claude Code