fix(app-check): validate provider name and error on unrecognized values

packages/app-check/__tests__/appcheck.test.ts

@@ -1,4 +1,5 @@
-import { describe, expect, it } from '@jest/globals';
+import { describe, expect, it, beforeEach, afterEach } from '@jest/globals';
+import { Platform } from 'react-native';
 
 import {
   initializeAppCheck,
@@ -26,6 +27,74 @@ describe('appCheck()', function () {
       );
     });
 
+    describe('provider name validation', function () {
+      it('throws on invalid android provider name', function () {
+        const provider = new ReactNativeFirebaseAppCheckProvider();
+        provider.configure({
+          android: { provider: 'invalidProvider' as any },
+        });
+        expect(() => initializeAppCheck(undefined, { provider })).toThrow(
+          'Invalid App Check provider "invalidProvider". Valid android providers are: debug, playIntegrity.',
+        );
+      });
+
+      it('does not throw validation error for valid android provider names', function () {
+        for (const name of ['debug', 'playIntegrity']) {
+          const provider = new ReactNativeFirebaseAppCheckProvider();
+          provider.configure({
+            android: { provider: name as any },
+          });
+          try {
+            initializeAppCheck(undefined, { provider });
+          } catch (e: any) {
+            expect(e.message).not.toContain('Invalid App Check provider');
+          }
+        }
+      });
+
+      describe('apple platform', function () {
+        let originalOS: string;
+
+        beforeEach(function () {
+          originalOS = Platform.OS;
+          Platform.OS = 'ios' as any;
+        });
+
+        afterEach(function () {
+          Platform.OS = originalOS as any;
+        });
+
+        it('throws on invalid apple provider name', function () {
+          const provider = new ReactNativeFirebaseAppCheckProvider();
+          provider.configure({
+            apple: { provider: 'appAttestWithDebugProviderFallback' as any },
+          });
+          expect(() => initializeAppCheck(undefined, { provider })).toThrow(
+            'Invalid App Check provider "appAttestWithDebugProviderFallback". Valid apple providers are: debug, deviceCheck, appAttest, appAttestWithDeviceCheckFallback.',
+          );
+        });
+
+        it('does not throw validation error for valid apple provider names', function () {
+          for (const name of [
+            'debug',
+            'deviceCheck',
+            'appAttest',
+            'appAttestWithDeviceCheckFallback',
+          ]) {
+            const provider = new ReactNativeFirebaseAppCheckProvider();
+            provider.configure({
+              apple: { provider: name as any },
+            });
+            try {
+              initializeAppCheck(undefined, { provider });
+            } catch (e: any) {
+              expect(e.message).not.toContain('Invalid App Check provider');
+            }
+          }
+        });
+      });
+    });
+
     it('`getToken` function is properly exposed to end user', function () {
       expect(getToken).toBeDefined();
     });

packages/app-check/android/src/main/java/io/invertase/firebase/appcheck/ReactNativeFirebaseAppCheckProvider.java

@@ -89,6 +89,15 @@ public String getDebugSecret() {
       if ("playIntegrity".equals(providerName)) {
         delegateProvider = PlayIntegrityAppCheckProviderFactory.getInstance().create(app);
       }
+
+      if (delegateProvider == null) {
+        String message =
+            "Unknown provider name \""
+                + providerName
+                + "\". Valid providers are: debug, playIntegrity.";
+        Log.e(LOGTAG, message);
+        throw new IllegalArgumentException(message);
+      }
     } catch (Exception e) {
       // This will bubble up and result in a rejected promise with the underlying message
       throw new RuntimeException(e.getMessage());

packages/app-check/ios/RNFBAppCheck/RNFBAppCheckProvider.m

@@ -73,6 +73,12 @@ - (void)configure:(FIRApp *)app
       self.delegateProvider = [[FIRDeviceCheckProvider alloc] initWithApp:app];
     }
   }
+
+  if (self.delegateProvider == nil) {
+    NSLog(@"RNFBAppCheck: Unknown provider name \"%@\". Valid providers are: debug, deviceCheck, "
+          @"appAttest, appAttestWithDeviceCheckFallback.",
+          providerName);
+  }
 }
 
 - (void)getTokenWithCompletion:(nonnull void (^)(FIRAppCheckToken *_Nullable,

packages/app-check/lib/index.ts

@@ -49,6 +49,14 @@ import { ReactNativeFirebaseAppCheckProvider } from './providers';
 
 const nativeModuleName = 'NativeRNFBTurboAppCheck';
 
+const VALID_APPLE_PROVIDERS = [
+  'debug',
+  'deviceCheck',
+  'appAttest',
+  'appAttestWithDeviceCheckFallback',
+];
+const VALID_ANDROID_PROVIDERS = ['debug', 'playIntegrity'];
+
 /**
  * Type guard to check if a provider has providerOptions.
  * This provides proper type narrowing for providers that support platform-specific configuration.
@@ -63,6 +71,29 @@ function hasProviderOptions(
   );
 }
 
+function validateProviderName(options: AppCheckOptions): void {
+  if (!hasProviderOptions(options.provider)) {
+    return;
+  }
+  const provider = options.provider;
+  if (Platform.OS === 'android') {
+    const name = provider.providerOptions?.android?.provider;
+    if (isString(name) && !VALID_ANDROID_PROVIDERS.includes(name)) {
+      throw new Error(
+        `Invalid App Check provider "${name}". Valid android providers are: ${VALID_ANDROID_PROVIDERS.join(', ')}.`,
+      );
+    }
+  }
+  if (Platform.OS === 'ios' || Platform.OS === 'macos') {
+    const name = provider.providerOptions?.apple?.provider;
+    if (isString(name) && !VALID_APPLE_PROVIDERS.includes(name)) {
+      throw new Error(
+        `Invalid App Check provider "${name}". Valid apple providers are: ${VALID_APPLE_PROVIDERS.join(', ')}.`,
+      );
+    }
+  }
+}
+
 class FirebaseAppCheckModule extends FirebaseModule<typeof nativeModuleName> {
   _listenerCount: number;
 
@@ -267,6 +298,7 @@ export function initializeAppCheck(app?: FirebaseApp, options?: AppCheckOptions)
   if (!isObject(options)) {
     throw new Error('Invalid configuration: no options defined.');
   }
+  validateProviderName(options);
   const appCheck = getModularAppCheck(app);
   void (appCheck as AppCheckInternal).initializeAppCheck(options);
   return appCheck;