fix(ios): set IPHONEOS_DEPLOYMENT_TARGET to 15.0 across all packages#9108
fix(ios): set IPHONEOS_DEPLOYMENT_TARGET to 15.0 across all packages#9108just1and0 wants to merge 2 commits into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9108 +/- ##
============================================
- Coverage 65.14% 65.11% -0.02%
Complexity 1833 1833
============================================
Files 503 503
Lines 39184 39184
Branches 5805 5776 -29
============================================
- Hits 25521 25510 -11
- Misses 12192 12242 +50
+ Partials 1471 1432 -39
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mikehardy
left a comment
There was a problem hiding this comment.
this is a good change as a start - can you add a cleanup chore commit that scans the entire ios codebase and cleans up any stale API availability checks that were looking for iOS 15 or below?
If there is a similar requirement that we're past for tvos/visionos/ipados/maccatalyst etc - that is, a deployment target that's stale and could be updated so the compiler knows more APIs are available - allowing us to clean out availability gates for those platforms, it would be good to get everything at once while we're here
Summary
Updates
IPHONEOS_DEPLOYMENT_TARGETfrom10.0to15.0in all 16 package pbxproj files and the_TEMPLATE_pbxprojAligns with the
iosTarget: "15.0"already declared inpackages/app/package.jsonsdkVersionsPrevents new packages generated from the template from reintroducing the stale
10.0valueFixes this
@availableannotation shouldn't be necessary unless the pbxproj IPHONEOS_DEPLOYMENT_TARGET is wrong #8882Test plan
IPHONEOS_DEPLOYMENT_TARGET = 10.0values remain across all pbxproj filesgit diff --checkclean — no whitespace issues