Skip to content

fix(ios): set IPHONEOS_DEPLOYMENT_TARGET to 15.0 across all packages#9108

Open
just1and0 wants to merge 2 commits into
mainfrom
fix/ios-deployment-target
Open

fix(ios): set IPHONEOS_DEPLOYMENT_TARGET to 15.0 across all packages#9108
just1and0 wants to merge 2 commits into
mainfrom
fix/ios-deployment-target

Conversation

@just1and0

@just1and0 just1and0 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Verified zero IPHONEOS_DEPLOYMENT_TARGET = 10.0 values remain across all pbxproj files
  • git diff --check clean — no whitespace issues
  • CI iOS build passes

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.11%. Comparing base (3bbfecc) to head (b282e60).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9108      +/-   ##
============================================
- Coverage     65.14%   65.11%   -0.02%     
  Complexity     1833     1833              
============================================
  Files           503      503              
  Lines         39184    39184              
  Branches       5805     5776      -29     
============================================
- Hits          25521    25510      -11     
- Misses        12192    12242      +50     
+ Partials       1471     1432      -39     
Flag Coverage Δ
android-native 60.52% <ø> (ø)
e2e-ts-android 58.21% <ø> (ø)
e2e-ts-ios 62.74% <ø> (-0.05%) ⬇️
e2e-ts-macos 50.01% <ø> (ø)
ios-native 62.74% <ø> (-0.05%) ⬇️
jest 49.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good change as a start - can you add a cleanup chore commit that scans the entire ios codebase and cleans up any stale API availability checks that were looking for iOS 15 or below?

If there is a similar requirement that we're past for tvos/visionos/ipados/maccatalyst etc - that is, a deployment target that's stale and could be updated so the compiler knows more APIs are available - allowing us to clean out availability gates for those platforms, it would be good to get everything at once while we're here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

this @available annotation shouldn't be necessary unless the pbxproj IPHONEOS_DEPLOYMENT_TARGET is wrong

2 participants