chore: cleanup vestigial old architecture java remnants#9109
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9109 +/- ##
============================================
+ Coverage 65.14% 65.82% +0.69%
+ Complexity 1833 1832 -1
============================================
Files 503 497 -6
Lines 39184 38754 -430
Branches 5805 5785 -20
============================================
- Hits 25521 25506 -15
+ Misses 12192 11813 -379
+ Partials 1471 1435 -36
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Going to merge this one as there is literally no code to review, it's all deletions of stale files I missed during new arch migraiton: Additionally, since there is a new PR that touches one of these files I was surprised to see laying around I want to get this in now so the new PR may be updated to reflect the new arch reality: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReactNativeFirebase*Module.javain app/utils, app, remote-config, perf, in-app-messaging, installations) left behind after the TurboModule migration. Runtime was already TurboModule-only; these classes were compiled but never registered, so they were unreachable.Test plan
yarn lintexit 0 on frozen tree