Support using Resources as parameter to resolve#285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a new copose lint warning LocalContextGetResourceValueCall that forces us to use LocalResources over LocalContext – for good reasons.
Since internally we use sometimes a
LaunchedEffectthat takes an argument that is NOT a@Composable, we still have to useLocalContext.current. Which is not an issue generally, however, we are now gett the Context as well as the Resources.I just added a simply overload to let us use TextRef with a resource as well.
With that change, we only need to get LocalResources and no LocalContext anymore.