Operator API | Change No Shows to Service Violations#753
Open
anm-ioki wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Operator API client to use the new “service violations” endpoints that replace the legacy “no shows” endpoints, including corresponding model renames and response shape updates.
Changes:
- Renames Operator API methods/endpoints from
no_shows/no_show_acknowledgetoservice_violations/service_violation_acknowledge. - Renames the model from
Ioki::Model::Operator::NoShowtoIoki::Model::Operator::ServiceViolation. - Adds the
service_violation_typeresponse attribute to the service violation model.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/ioki/operator_api_spec.rb | Updates Operator API specs to assert the new service violations endpoints/method names and model class. |
| lib/ioki/model/operator/service_violation.rb | Renames the model class and adds the service_violation_type attribute. |
| lib/ioki/apis/operator_api.rb | Switches endpoint registrations from no_shows to service_violations and updates acknowledge action routing. |
Comments suppressed due to low confidence (1)
lib/ioki/model/operator/service_violation.rb:47
- Renaming
NoShowtoServiceViolationremoves theIoki::Model::Operator::NoShowconstant entirely, which is a breaking change for consumers who type-check against that class. If backwards compatibility is desired, provide a deprecated alias constant so existing code keeps working.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #745
The Operator API now has new endpoints for service violations to replace the existing no shows. These changes use the new endpoints and rename the models accordingly. Additionally, there's a new response attribute for the type of service violation, which for now will just be 'no_show' until new functionality is added to triebwerk.