Conversation
…hell-owned conn_io map
…ndency-free crate Inject the keepalive wire timestamp (create_keepalive_packet[_ext] now take now) so the protocol has zero crate-internal deps, then move src/protocol into a new srtla-protocol workspace crate. The sender aliases it as crate::protocol, so every existing crate::protocol::* reference keeps resolving.
process_packet was an inherent impl SrtlaConnection method holding the receive path's tokio UdpSocket + mpsc coupling. Move it verbatim (ACK fast-path intact) into sender::uplink_recv::process_uplink_packet(conn, ...) so the connection state carries no receive-side I/O.
…pure CriticalWindow Move spawn_listener (tokio UDP) into a new priority_listener shell module; add CriticalWindow::record_malformed so the listener needs no private-field access. priority.rs (CriticalWindow + select_best_quality_idx) is now tokio-free in production.
selection is core scheduler logic, mutually dependent with connection (connection calls calculate_quality_multiplier; selection operates on SrtlaConnection), so it cannot live under the sender shell. Move src/sender/selection -> src/selection and repoint connection to crate::selection, breaking the last core->shell dependency. sender keeps crate::sender::* re-exports for the test/telemetry surface.
… net module Move BatchUdpSocket (batch_recv) and the socket/binder helpers (socket.rs) plus send_all_datagrams into a new top-level net shell module, and relocate the shared BATCH_SEND_SIZE constant into connection (core) so net depends on core, not the reverse. connection/ now holds only pure, tokio-free protocol state.
…ynamicConfig DynamicConfig couples to the control dispatcher and SharedStats (shell), but the scheduler core only needs the pure ConfigSnapshot. Move ConfigSnapshot + its STALL_* default consts into a new config_snapshot core module; DynamicConfig re-exports them for the existing crate::config::* paths. selection now depends on config_snapshot, not config — the last core->shell config leak.
…ths, drop boundary shims
…n dwell the staleness window now scales with smoothed rtt (4x, floored at 1s, capped at the configured ceiling) so a fast link is pulled within hundreds of ms of going dark. gating latches asymmetrically: engage on the raw stall signal, release only after an uninterrupted run of fresh delivery proof spanning twice the effective window, so a backlog drained by cumulative acks or a single keepalive echo can no longer flap a still-marginal link back into rotation. adds a per-link gate-event counter and a 1-in-n duplicate-probe cadence helper.
srt packets carrying the retransmit flag now route through the best-quality override: recovery traffic that rides a degraded link arrives too late to fill the hole it was resent for. stall-gated links receive a copy of every nth routed data packet; the duplicate is deduped by the srt receiver so it can never stall the buffer, while a delivered one earns the gated link the data-sized delivery proof its rejoin dwell requires. srtla acks now match the arrival link's packet log first so a probe's ack credits the link that actually delivered it.
Contributor
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (66)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.