Skip to content

Adding original signal to the list of 'processed' signals - #108

Merged
olivhoenen merged 2 commits into
iterorganization:developfrom
jwasikpsnc:bugfix/107-error-if-original-signal-used-for-operations
Jul 31, 2026
Merged

Adding original signal to the list of 'processed' signals#108
olivhoenen merged 2 commits into
iterorganization:developfrom
jwasikpsnc:bugfix/107-error-if-original-signal-used-for-operations

Conversation

@bpalak

@bpalak bpalak commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@bpalak bpalak changed the title Adding original signal to the list of 'processed' signals WIP: Adding original signal to the list of 'processed' signals Jul 28, 2026
@bpalak bpalak changed the title WIP: Adding original signal to the list of 'processed' signals Adding original signal to the list of 'processed' signals Jul 30, 2026
@bpalak

bpalak commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

One of pytests still needs to be updated.

@olivhoenen

Copy link
Copy Markdown
Contributor

Thanks @bpalak. Can you specify which issue / PR-comment / user-story this is addressing? (is this linked to #107 ?)

@bpalak

bpalak commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Yes, this PR addresses #107
The issue was: even resampled 'target' signal could not be used as argument for signal operations. The code reads the signal from scratch - it caused incompatibilities between 'resampled' and 'original' signal coordinates.

@olivhoenen olivhoenen linked an issue Jul 31, 2026 that may be closed by this pull request
@olivhoenen
olivhoenen merged commit 19644b4 into iterorganization:develop Jul 31, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resample_data_without_interpolation function behaviour

2 participants