ci: pull phpfpm and its dependencies up front in workflow templates#147
Open
turegjorup wants to merge 1 commit into
Open
ci: pull phpfpm and its dependencies up front in workflow templates#147turegjorup wants to merge 1 commit into
turegjorup wants to merge 1 commit into
Conversation
dc041bd to
2df739c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull the
phpfpmservice and its dependencies up front withdocker compose pull --quiet --include-deps phpfpm, so the images download in parallel before the job runs instead of lazily duringdocker compose run.Changes
phpfpm:github/workflows/composer.yaml(validate, normalize, audit)github/workflows/twig.yamlgithub/workflows/drupal/php.yamlgithub/workflows/drupal-module/php.yamlgithub/workflows/symfony/php.yamlWhy
phpfpmdeclaresdepends_on: mariadb(andmemcachedfor Drupal), sodocker compose run --rm phpfpm …brings up several services. Pulling with--include-depsup front fetches those images in parallel before the run, for faster and cleaner jobs.Notes
runalready does — left unchanged.github/workflows/drupal/site.yamlalready pulls the full stack up front (docker compose pull) and is unchanged.