Max IV Evolution implementation with hooks for other implementations#444
Max IV Evolution implementation with hooks for other implementations#444devinsba wants to merge 18 commits into
Conversation
| val pokebagFillPercent = ctx.api.inventories.pokebank.pokemons.size.toDouble() / ctx.profile.pokemonStorage | ||
| Log.white("Pokebag ${pokebagFillPercent * 100} % full.") | ||
| val groupedPokemon = ctx.api.inventories.pokebank.pokemons.groupBy { it.pokemonId } | ||
| if (pokebagFillPercent >= 0.7) { |
There was a problem hiding this comment.
This value should be a setting
|
FYI regarding Eevee evolves http://gamerant.com/pokemon-go-guide-eevee-evolution-flareon-vaporeon-jolteon/ tl;dr Rename pokemon:
|
|
Eevee easter egg only works first time for every pokemon. For example you can't get more than 1 vaporeon with 100% accuracy. |
|
Good to know. |
|
Why dont you merge this already @jabbink ? What is the problem holding it back? |
I would guess because it is a Work In Progress (WIP). Why don't you pull it down on your own, check it out, and report back if it is operational? |
|
I had been running it until the API lockdown. I have some code I haven't On Sun, Jul 31, 2016 at 8:51 PM, JJ notifications@github.com wrote:
|
| if (settings.shouldAutoTransfer) { | ||
| task(release) | ||
| } else { | ||
| task(smartEvolve) |
There was a problem hiding this comment.
Why don't allow evolving and transferring as well?
There was a problem hiding this comment.
It happened to fit what I was planning on at the time. I am considering the final touches to make this all configurable now.
|
@jabbink should I do a rebase on this to clean up the commit history? |
devinsba
changed the title
| */ | ||
| class Evolve : Task { | ||
|
|
||
| private val DEFAULT_EVOLUTION_STRATEGY = "max_iv" |
There was a problem hiding this comment.
The implementation in #939 should be the default implementation but I just put mine in here as a placeholder
|
@jabbink this is no longer WIP status |
|
i think there is a logic error in evolving..... |
Compatible with #939 Don't care about bag fullness anymore Only run in the profile loop
5 participants
Attempting to get #347 working more cleanly with the API and a few things I wanted