Conversation
|
coverage: 93.739% (+0.06%) from 93.684% — grimoire into master |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Resyntax analyzed 11 files in this pull request and found no issues.
The grimoire documents that reading and expanding a file source parameterizes the current directory to the source's parent directory, but that parameterization only happened in source-analyze, not in the source module itself. Now source-read-syntax, source-read-language, and source-expand (and thus source-can-expand?) each parameterize the current directory for file-based sources, so relative module imports resolve correctly no matter the caller's working directory. The existing parameterization in source-analyze stays, since it calls expand directly rather than source-expand. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Resyntax analyzed 11 files in this pull request and found no issues.
Contributor
There was a problem hiding this comment.
Resyntax analyzed 11 files in this pull request and found no issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the start of an effort to make Resyntax's internals more understandable by documenting them. However, while this is intended to make it easier to understand Resyntax's internals, it is not intended to encourage directly relying upon them. For that reason, I've chosen to name this section "The Resyntax Grimoire", because dangerous knowledge that may doom the arrogant awaits within. I reserve the right to change any API documented in the grimoire at any time, subject to my own judgment.