Update to .NET 10 SDK, xunit.v3.mtp-v2 + MTP, slnx, SDK-integrated package validation#275
Merged
Merged
Conversation
…ckage validation Agent-Logs-Url: https://github.com/jet/propulsion/sessions/39e9f736-defc-4446-9e78-3fd1760f8bce Co-authored-by: bartelink <206668+bartelink@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
bartelink
May 6, 2026 06:58
View session
|
|
bartelink
reviewed
May 6, 2026
There was a problem hiding this comment.
Pull request overview
This PR modernizes Propulsion’s build/test toolchain to .NET 10, migrating test execution to xUnit v3 on Microsoft Testing Platform (MTP), moving the repo to the .slnx solution format, and switching package validation to the SDK-integrated mechanism.
Changes:
- Upgrade SDK pinning to .NET
10.0.201and optdotnet testinto Microsoft Testing Platform viaglobal.json. - Migrate test projects to
net10.0andxunit.v3.mtp-v2(+FsCheck.Xunit.v3where applicable), including required xUnit v3 API/behavior updates. - Replace per-project PackageValidation SDK usage with centralized
EnablePackageValidationand update CI/build inputs to usePropulsion.slnx.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Propulsion.Tests/TestOutputLogger.fs | Update output helper type for xUnit v3 namespace. |
| tests/Propulsion.Tests/SourceTests.fs | Resolve .NET 10 TimeSpan.From* literal ambiguities with L suffix. |
| tests/Propulsion.Tests/SinkHealthTests.fs | Resolve .NET 10 TimeSpan.From* literal ambiguities with L suffix. |
| tests/Propulsion.Tests/Propulsion.Tests.fsproj | Move to net10.0, set OutputType=Exe, and switch to xUnit v3 MTP packages. |
| tests/Propulsion.MessageDb.Integration/Tests.fs | Resolve .NET 10 TimeSpan.From* literal ambiguities with L suffix. |
| tests/Propulsion.MessageDb.Integration/Propulsion.MessageDb.Integration.fsproj | Move to net10.0, set OutputType=Exe, and switch to xUnit v3 MTP package. |
| tests/Propulsion.Kafka.Integration/Propulsion.Kafka.Integration.fsproj | Move to net10.0, set OutputType=Exe, and switch to xUnit v3 MTP package. |
| tests/Propulsion.Kafka.Integration/MonitorIntegration.fs | Resolve .NET 10 TimeSpan.From* literal ambiguities with L suffix. |
| tests/Propulsion.Kafka.Integration/ConsumersIntegration.fs | Adjust FactIfBroker to set sealed xUnit v3 properties in constructor. |
| src/Propulsion/Propulsion.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.SqlStreamStore/Propulsion.SqlStreamStore.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.Prometheus/Propulsion.Prometheus.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.MessageDb/Propulsion.MessageDb.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.MemoryStore/Propulsion.MemoryStore.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.Kafka/Propulsion.Kafka.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.EventStoreDb/Propulsion.EventStoreDb.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.EventStore/Propulsion.EventStore.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.DynamoStore/Propulsion.DynamoStore.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.DynamoStore.Lambda/Propulsion.DynamoStore.Lambda.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.DynamoStore.Constructs/Propulsion.DynamoStore.Constructs.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.CosmosStore3/Propulsion.CosmosStore3.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| src/Propulsion.CosmosStore/Propulsion.CosmosStore.fsproj | Remove legacy Microsoft.DotNet.PackageValidation SDK usage. |
| Propulsion.slnx | Introduce .slnx solution format and list projects/files. |
| global.json | Pin .NET SDK 10.0.201 and opt into MTP test runner. |
| Directory.Build.props | Enable SDK-integrated package validation for Release builds. |
| CHANGELOG.md | Document the upgrade/migration changes. |
| build.proj | Adjust dotnet test options for new runner/logging pipeline. |
| azure-pipelines.yml | Remove explicit .NET SDK provisioning step from Linux job. |
| .github/workflows/ci.yaml | Update checkout action and switch build/test to Propulsion.slnx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernises the build and test stack to .NET 10, replacing the legacy xunit/VSTest pipeline with Microsoft Testing Platform (MTP) and cleaning up accumulated workarounds.
SDK & CI
global.json: SDK10.0.201+ MTP opt-in via"test": { "runner": "Microsoft.Testing.Platform" }azure-pipelines.yml: drop redundantUseDotNet@2workaround stepci.yaml:actions/checkout@v2→@v4; switch build/test toPropulsion.slnxTest projects
xunit+Microsoft.NET.Test.Sdk+xunit.runner.visualstudiowithxunit.v3.mtp-v2(3.2.2) andFsCheck.Xunit.v3(3.3.3)net10.0; add<OutputType>Exe</OutputType>(required by xunit v3)Xunit.Abstractions.ITestOutputHelper→Xunit.ITestOutputHelper(xunit v3 namespace)FactIfBroker: xunit v3 sealsSkip/TimeoutonFactAttribute— switch fromoverrideto setting properties in the constructor body:int64overloads toTimeSpan.From*, making bare integer literals ambiguous — resolved withLsuffix throughout (e.g.TimeSpan.FromSeconds 1L)Package validation
<Sdk Name="Microsoft.DotNet.PackageValidation" .../>from all 13 library projects<EnablePackageValidation>true</EnablePackageValidation>inDirectory.Build.props(Release only) — SDK-integrated since .NET 8Solution
Propulsion.sln→Propulsion.slnxviadotnet solution migrate