fix: numeric string arrays incorrectly treated as identical#95
Merged
Conversation
PHP 8's <=> operator compares numeric string arrays using numeric semantics, causing "00" and "0" (or "1" and "01", "10" and "1e1") to be treated as identical. This made the renderer short-circuit and return empty output for inputs that differ only in numeric string representation. Use === for the equality check and fall back to <=> only for ordering, forcing a non-zero result when arrays are strictly different.
Owner
|
Thanks alot :D |
jfcherng
changed the title
jfcherng
pushed a commit
that referenced
this pull request
Jun 22, 2026
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8's
<=>compares numeric string arrays numerically, so['00'] <=> ['0']returns 0. The renderer sees this as "identical" and returns empty output.Fix: check
===first for equality, only use<=>for ordering. Force non-zero when arrays differ but spaceship says otherwise.Reproducer:
Fixes #94