feat: align parentheses closer with Prettier JS/TS, including their removal#944
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed with this PR:
Printing of parentheses is aligned much more closely with Prettier JS/TS, most notably, parentheses are removed similarly to Prettier JS/TS. Any
ParenthesizedExpressionnodes not required by their parent node (such as inIfStatement,SwitchExpression, etc.) are omitted from the syntax tree, similar to Prettier JS/TS, and only added if necessary to keep the logic identical, for compilation, or for readability, with rules kept as close to those defined in Prettier JS/TS as possible. Includes a few other random fixes by aligning more closely with Prettier JS/TS, such as the indentation alignment of nested ternaries and the placement of&in cast expressions with multiple bounds.Example
Input
Output
Relative issues or prs:
Closes #770
Closes #921