Skip to content

Update GitHub scraping example in GUIDE.md#1424

Open
JosXa wants to merge 1 commit into
johnlindquist:mainfrom
JosXa:patch-1
Open

Update GitHub scraping example in GUIDE.md#1424
JosXa wants to merge 1 commit into
johnlindquist:mainfrom
JosXa:patch-1

Conversation

@JosXa

@JosXa JosXa commented Jan 11, 2024

Copy link
Copy Markdown
Contributor

Was trying out the example, seems the span is required to get to the anchor now.

Without:

[2024-01-11 22:32:22.571] [info]  []

With:

[2024-01-11 22:33:35.211] [info]  [{"link":"https://github.com/johnlindquist/kit","title":"kit"},{"link":"https://github.com/johnlindquist/angularjs-plugin","title":"angularjs-plugin"},{"link":"https://github.com/johnlindquist/react-streams","title":"react-streams"},{"link":"https://github.com/johnlindquist/angular-resolve","title":"angular-resolve"},{"link":"https://github.com/johnlindquist/rx-handler","title":"rx-handler"},{"link":"https://github.com/johnlindquist/intro-to-angular2","title":"intro-to-angular2"}]

@JosXa

JosXa commented Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

It's approved. Merge too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants