🔒 Fix application crash on unhandled Symbol properties in proxies#21
Conversation
Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed a vulnerability in
createStoreproxies (usePendinganduseSquawk) where arbitrary symbol properties were being mistakenly added to internal state trackers, causing potential application crashes.Symboloff of them, the symbol was improperly tracked as a string context. This would cause downstream string manipulations on the context tracker to fail catastographically, taking down the frontend application.🛡️ Solution: Modified the
gettrap in bothusePendinganduseSquawkproxies to only register the property in the context trackerif (typeof prop === "string"). Non-string property accesses (like Symbols) simply return the value normally without attempting to track them. Includes accompanying unit tests for safety.PR created automatically by Jules for task 14356909526467052655 started by @johnstrand