⚡ Optimize state initialization in hooks using lazy evaluation#28
Conversation
Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Modified
useSquawkandusePendingto use lazy initialization foruseStateby passing an initializer function() => globalState.get()and() => pendingState.get()instead of directly calling.get().🎯 Why: Previously,
useStateevaluated its argument on every single re-render of components using these hooks. For large global states with deep structures, callingglobalState.get()causes a full shallow copy (Object spread{ ...globalState }) which is a significant waste of CPU time and triggers unnecessary garbage collections, consideringuseStateignores the argument on subsequent renders. Lazy initialization prevents this.📊 Measured Improvement:
A benchmark simulating a component performing 10,000 forced re-renders connected to a store with 10,000 keys was created and run on the baseline and the optimized code using
react-test-renderer:PR created automatically by Jules for task 8646321819898523556 started by @johnstrand