⚡ [performance] Optimize pendingSubscribersInternal allocation#29
Conversation
Extract pendingState.get() evaluation outside of the pendingSubscribersInternal.forEach loop to avoid redundant object allocations. Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Extracted
pendingState.get()from inside thependingSubscribersInternal.forEachloop and guarded it with anif (pendingSubscribersInternal.size > 0)check.🎯 Why: Previously, iterating over
pendingSubscribersInternaltriggered a call topendingState.get()for each iteration. Because.get()performs an object spread ({ ...globalState }), this caused massive redundant allocations that scaled linearly with the number of pending subscribers and loop iterations. Extracting this call to a local variable ensures the object allocation happens exactly once.📊 Measured Improvement:
A dedicated benchmark was written to invoke the
pending()dispatch over 10,000 loop cycles with an artificially high count of subscribers.PR created automatically by Jules for task 17485904325157326600 started by @johnstrand