⚡ perf: optimize usePending state initialization#30
Conversation
Update `useState(pendingState.get())` to use lazy initialization `useState(() => pendingState.get())` in `usePending`. This avoids unnecessary eager evaluation of the pending state on every re-render. Co-authored-by: johnstrand <11484777+johnstrand@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Updated
useState(pendingState.get())touseState(() => pendingState.get())inside theusePendingmethod insrc/Squawk.ts.🎯 Why:
React's
useStateeagerly evaluates its initial argument on every render, even though it only uses the result on the initial mount.pendingState.get()performs a spread operationreturn { ...globalState } as Readonly<T>;which involves an unnecessary allocation. Using a lazy initializer function() => pendingState.get()ensures this logic only runs once when the component initially mounts, preventing wasted CPU cycles and allocations on subsequent renders.📊 Measured Improvement:
I established a benchmark (
benchmark2.ts) that created a component usingusePending, and artificially triggered 10,000 updates viareact-test-renderer.PR created automatically by Jules for task 896503977257741069 started by @johnstrand