Fix RouterInterface status when Router is not Available - #863
Open
IlanZuckerman wants to merge 1 commit into
Open
Fix RouterInterface status when Router is not Available#863IlanZuckerman wants to merge 1 commit into
IlanZuckerman wants to merge 1 commit into
Conversation
When a Router exists but is not yet Available, the routerinterface controller returned early without writing RouterInterface status, leaving .status empty and hard to diagnose. Mirror the NotFound path: update dependent RouterInterfaces with WaitingOnObject(..., WaitingOnReady) so status shows they are waiting for the Router to be ready. Add a KUTTL test covering this scenario. Fixes k-orc#838
Member
|
Sounds good to me. Thanks @IlanZuckerman. I would like to see what the CI thinks before approving it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a Router exists but is not yet Available, the routerinterface controller returned early without writing RouterInterface status, leaving
.statusempty and hard to diagnose.Today, if the Router is missing we write a helpful status on
RouterInterfaces.If the Router exists but is not ready we write nothing.
This change makes the not-ready case also write status: “Waiting for Router/ to be ready.”
Add a KUTTL test covering this scenario.
Fixes #838