note the post-thread-safety grpc benchmark bump in performance.md#434
Open
kacy wants to merge 1 commit into
Open
note the post-thread-safety grpc benchmark bump in performance.md#434kacy wants to merge 1 commit into
kacy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
re-ran the full benchmark suite after the thread-safety sweep (#430-#433). the compute benchmarks (std_pipeline, catalog_workload, event_ledger, cyclic_graph) are unchanged within the box's noise — those paths don't touch tls/binary/grpc. the grpc benchmark improved: moving std.binary's reader off shared global maps into struct fields (#430) dropped a global-map access per frame parse, so a re-measurement put pith at ~3040 calls/sec sequential 16 B (matching tonic) and ~6300 8-concurrent (~2x scaling), while making the connection pool safe under real parallelism (it previously raced the global maps and crashed).
what was tested
ran grpc (pith/go/rust sweep), std_pipeline, catalog_workload, event_ledger (pith/go/rust/zig), cyclic_graph — all against the current build. docs-only change; the grpc numbers are the notable delta.