Skip to content

chore(release): enrich chocolatey nuspec metadata per moderation guidelines#510

Open
Matovidlo wants to merge 1 commit into
mainfrom
martinvasko-chore-chocolatey-nuspec-guidelines
Open

chore(release): enrich chocolatey nuspec metadata per moderation guidelines#510
Matovidlo wants to merge 1 commit into
mainfrom
martinvasko-chore-chocolatey-nuspec-guidelines

Conversation

@Matovidlo

Copy link
Copy Markdown
Contributor

Summary

Enriches the Chocolatey package nuspec (build/package/chocolatey/keboola-cli2.nuspec) to address the Guidelines flagged by chocolatey-ops on the keboola-cli2 0.66.1 moderation review.

  • Add packageSourceUrl, projectSourceUrl, bugTrackerUrl
  • Add releaseNotes as a URL to the releases page (moderator-endorsed form → never needs per-version edits)
  • Add copyright
  • Stage a commented-out iconUrl (jsDelivr CDN) ready to enable once an icon PNG is committed — left off deliberately to avoid a 404 link, which is worse than omitting it

Context — why the Chocolatey channel is currently stuck (not this PR)

The 403 Forbidden on choco push for 0.71.0 / 0.72.0 is not a pipeline or key bug. It's the documented Chocolatey behavior: a package with a version in moderation and no approved version rejects new-version pushes with 403. keboola-cli2 0.66.1 passed automated validation on 2026-07-15 with zero Requirements and is simply waiting in the human moderation queue. When a moderator approves 0.66.1, the block lifts and 0.71/0.72 can push (re-run the failed job, no new tag needed).

The reviewer's comments were all Guidelines / Suggestions / Notes — explicitly "fix for next time," approvable without them. This PR is that quality polish; it ships with the next published version.

Impact analysis

  • build/package/chocolatey/keboola-cli2.nuspec: additive metadata only. XML validated well-formed.
  • No workflow change, no secret change, no behavior change to the built binary.
  • Fully backwards-compatible; affects only the metadata shown on the Chocolatey package page.

Test plan

  • python3 -c "import xml.dom.minidom; xml.dom.minidom.parse(...)" → XML well-formed ✅
  • iconUrl intentionally commented until build/package/chocolatey/keboola.png is committed; uncomment then.

Change type

Chore — Chocolatey packaging metadata quality (no functional change)

Related

Deployment

Merge & picked up by the next release's chocolatey packaging step. No migration.

Rollback plan

Revert of this PR.

Post release support plan

None.

…elines

Address the Guidelines flagged by chocolatey-ops on the keboola-cli2 0.66.1
moderation review (all Guidelines/Suggestions -- zero Requirements, so this is
quality polish for the next published version, not a blocker):

- add packageSourceUrl, projectSourceUrl, bugTrackerUrl
- add releaseNotes (URL form -> no per-version edits, moderator-endorsed)
- add copyright
- stage a commented-out iconUrl (jsDelivr CDN) ready to enable once an icon
  PNG is committed; left off to avoid a 404 link

Does NOT touch the workflow: the chocolatey push 403 on 0.71/0.72 is caused by
0.66.1 sitting in moderation with no approved version yet (documented chocolatey
403 trigger), which resolves when a moderator approves 0.66.1 -- not by anything
in the release pipeline.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Matovidlo

Copy link
Copy Markdown
Contributor Author

@claude review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Chocolatey nuspec metadata for keboola-cli2 to better align with Chocolatey moderation guidelines, improving the package’s listing quality without changing any runtime behavior.

Changes:

  • Added repository/source metadata fields (packageSourceUrl, projectSourceUrl, bugTrackerUrl).
  • Added URL-form releaseNotes and copyright.
  • Staged (commented-out) iconUrl with guidance for enabling it once an icon asset exists.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build/package/chocolatey/keboola-cli2.nuspec
@Matovidlo
Matovidlo marked this pull request as ready for review July 21, 2026 09:04
@Matovidlo
Matovidlo requested a review from padak July 21, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants