Fix/bugs 293 298 299 300 - #369
Open
krypto-boi wants to merge 2 commits into
Open
Conversation
…usk#300 - kellymusk#293: expand format:check to cover all ts/tsx/css/json/md files - kellymusk#298: rewrite check-env.sh to validate all 20+ required env vars including Upstash Redis, M-Pesa, MTN MoMo, Paystack, Flutterwave, Sentry and Vercel variables - kellymusk#299: set skipWaiting to false in PWA config and add PwaUpdateBanner component so in-flight payment flows are not interrupted by SW updates - kellymusk#300: replace hardcoded cNGN balance in SendModal with live value from useBalanceContext() keyed on the selected currency
|
@krypto-boi is attempting to deploy a commit to the kelly musk's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@krypto-boi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: fix: resolve bugs #293, #298, #299, #300
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Description:
Summary
This PR addresses four bugs identified in the backlog. All changes are isolated, tested locally, and ready for review.
Closes #293
Closes #298
Closes #299
Closes #300
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Changes
#293 — Formatter scope too narrow
Expanded the format:check script to cover all relevant file types: .ts, .tsx, .css, .json, and .md. Previously only a subset of
files were being checked, allowing formatting inconsistencies to slip through CI.
#298 — Incomplete environment variable validation
Rewrote scripts/check-env.sh to validate all 20+ required environment variables across every integration — Upstash Redis, M-Pesa,
MTN MoMo, Paystack, Flutterwave, Sentry, and Vercel. The previous script missed several critical vars, making misconfigured
deployments hard to catch early.
#299 — Service Worker updates interrupting active payment flows
Set skipWaiting to false in the PWA config and introduced a new PwaUpdateBanner component. Updates now wait for the user to
acknowledge before activating the new service worker, preventing in-flight payment sessions from being wiped mid-transaction.
#300 — Hardcoded balance in Send Modal
Replaced the hardcoded cNGN balance in SendModal with a live value pulled from useBalanceContext(), keyed on the currently
selected currency. Users now see their real balance for any asset they choose to send.
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Files Changed
┌─────────────────────────────────────┬──────────────────────────────────────────────┐
│ File │ Change │
├─────────────────────────────────────┼──────────────────────────────────────────────┤
│ scripts/check-env.sh │ Full rewrite for complete env var coverage │
├─────────────────────────────────────┼──────────────────────────────────────────────┤
│ next.config.mjs │ Set skipWaiting: false in PWA config │
├─────────────────────────────────────┼──────────────────────────────────────────────┤
│ components/pwa-update-banner.tsx │ New component for user-controlled SW updates │
├─────────────────────────────────────┼──────────────────────────────────────────────┤
│ components/dashboard/send-modal.tsx │ Live balance via useBalanceContext() │
├─────────────────────────────────────┼──────────────────────────────────────────────┤
│ app/layout.tsx │ Mount PwaUpdateBanner │
├─────────────────────────────────────┼──────────────────────────────────────────────┤
│ db/notifications.json │ Seed data for notifications │
├─────────────────────────────────────┼──────────────────────────────────────────────┤
│ package.json / package-lock.json │ Dependency updates │
└─────────────────────────────────────┴──────────────────────────────────────────────┘
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Testing