Allow lock update to remove stale skill lock entries#102
Merged
Conversation
github-actions
Bot
added
kind/bug
needs-triage
needs-priority
needs-actor
release-note
labels
gjkim42
marked this pull request as ready for review
July 2, 2026 13:48
gjkim42
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
kanon lock update <provider-name>previously only accepted enabled git skill providers. After a provider was removed fromkanon.yaml, its stalekanon.lockentry could not be named and removed with the intended command.This updates named lock updates to accept provider names found only in
kanon.lockas stale, remove those stale entries, and keep remaining provider lock entries complete. It also handles legacy lock-owner forms where a removed provider name can be ambiguous, such as providergit.foostored asskill.git.foo.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Validated with
make test,make verify, and post-fix review-all.Does this PR introduce a user-facing change?