Skip to content

Refine Kanon worker test and documentation guidance#1255

Open
kelos-bot[bot] wants to merge 1 commit into
mainfrom
kanon-config-update-latest
Open

Refine Kanon worker test and documentation guidance#1255
kelos-bot[bot] wants to merge 1 commit into
mainfrom
kanon-config-update-latest

Conversation

@kelos-bot

@kelos-bot kelos-bot Bot commented May 31, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the Kanon worker instructions with four focused conventions backed by Kanon review feedback:

  • Kanon PR Add config file support with direct token credentials #16 review (P2, internal/core/apply_test.go) found that a two-outcome prune safety guard was untested in both directions and that project scope was covered only indirectly through agent scope. The worker now must assert both outcomes of safety guards and directly test narrowed flag/scope behavior.
  • Kanon PR Rename Go module to gjkim42/axon and add CLI install instructions #11 review (P3, internal/core/render_test.go:59) found that removing permission rendering had no negative assertion, allowing removed keys to return unnoticed. The worker now must add negative assertions when behavior is removed or disabled.
  • Kanon PR Update README.md to reference singularity/axon-workers.yaml #68 review (P2, README.md:62) found that the generated user-facing status behavior change omitted the matching README update. The worker now must update README.md in the same PR as a user-facing behavior change.

The branch previously duplicated PR-template and general testing guidance. Kanon now provides those conventions in its repository-level AGENTS.md, so this update removes that overlap and keeps only the review-specific gaps that are not already covered there.

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

There were no Kanon PRs in the last seven days. The audit therefore inspected the requested recent-20 set, including diffs, reviews, inline comments, and conversations for PRs with review activity and generated-by-Kelos PRs. Generated PRs #29 and #22 had older feature-specific findings that are either covered by current AGENTS.md or did not recur across PRs, so no broader rules were added for them.

Only self-development/kanon/kanon-workers.yaml is changed. make verify passes.

Does this PR introduce a user-facing change?

NONE

@gjkim42 gjkim42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to refine kanon-development? self-development has the same instructions but it works fine.
/kelos pick-up

@kelos-bot

kelos-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Task Status

Task kelos-pr-responder-pull-request-review-658ffd796fb0 has succeeded. ✅

@kelos-bot
kelos-bot Bot force-pushed the kanon-config-update-latest branch from acb3127 to ec8dcdc Compare June 1, 2026 00:37
@kelos-bot kelos-bot Bot changed the title Make Kanon worker follow the PR template and label gates Give the Kanon worker standing PR-template guidance for the label gate Jun 1, 2026
@kelos-bot

kelos-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Agent @gjkim42

Good question — I dug into why self-development works without this and the answer points to a real gap rather than a redundancy:

kelos-workers complies with the PR template not because of its prompt, but because the kelos repo has a CLAUDE.md ("Always follow .github/PULL_REQUEST_TEMPLATE.md…"). That standing guidance is what clears the label gate. The kanon repo has no CLAUDE.md (verified via the GitHub API and a code search), so kanon-workers got no equivalent guidance from anywhere — and after kanon PR #8 added check-pr-labels, its PRs would trip the gate.

I've reworked the change to match how self-development does it: the convention now lives in the kanon-workers-agent agentsMD (the agent's standing instructions, the kanon analog of kelos's CLAUDE.md), and the numbered procedure steps are reverted to be identical to kelos-workers. Net diff is now just a 10-line ## Pull Requests section.

If you'd prefer this live in a CLAUDE.md added to the kelos-dev/kanon repo itself (which would also cover the other kanon agents and human contributors), I'm happy to open that as a follow-up against kanon instead — let me know.

@kelos-bot kelos-bot Bot changed the title Give the Kanon worker standing PR-template guidance for the label gate Give the Kanon worker PR-template and testing conventions Jun 1, 2026
@kelos-bot
kelos-bot Bot force-pushed the kanon-config-update-latest branch from 13e0c5f to 5f51b8c Compare July 14, 2026 18:35
@kelos-bot kelos-bot Bot changed the title Give the Kanon worker PR-template and testing conventions Refine Kanon worker test and documentation guidance Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant