Integrate Kanon into agent config rendering#1322
Open
kelos-bot[bot] wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
/kelos review |
Contributor
Author
|
🤖 Kelos Task Status Task |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Bakes a pinned
kanonbinary into all five bundled agent images and adds a shared helper for applying controller-generated Kanon source config inside agent entrypoints.The controller now emits
KELOS_KANON_CONFIGfrom existing AgentConfig instructions and MCP servers while preserving the existingKELOS_AGENTS_MD,KELOS_MCP_SERVERS, andKELOS_PLUGIN_DIRenv vars. The Codex and Claude Code entrypoints use Kanon for instructions and MCP rendering, then keep the existing plugin handling so current plugin paths and agent bundles do not change. Gemini, OpenCode, and Cursor keep the legacy rendering paths until Kanon has matching adapters.Which issue(s) this PR is related to:
Fixes #1237
Special notes for your reviewer:
3edde4571b0aad2530627d94c8d2624ab44a3952because the Kanon repository has no release tag yet.make test,make verify,git diff --check, and a smoke test that the shared helper applies config with the real Kanon binary for Codex and Claude.Does this PR introduce a user-facing change?
Summary by cubic
Integrates
kanoninto all agent images and switches Codex and Claude Code to render AgentConfig instructions and MCP servers via Kanon, preserving existing env vars and plugin behavior. Improves consistency of config application without changing the AgentConfig API.kanonto all bundled agent images and a sharedapply_kanon_env_confighelper.KELOS_KANON_CONFIGbuilt from AgentConfig instructions and MCP servers.KELOS_PLUGIN_DIRhandling remains unchanged.KELOS_AGENTS_MD,KELOS_MCP_SERVERS, andKELOS_PLUGIN_DIRfor compatibility.Written for commit 6ac4a1f. Summary will update on new commits.