Support Markdown tables in session server#1507
Merged
Merged
Conversation
gjkim42
marked this pull request as ready for review
July 17, 2026 12:09
Collaborator
|
/kelos review |
Contributor
Author
|
🤖 Kelos Task Status Task |
Contributor
Author
|
🤖 Kelos Reviewer Agent @gjkim42 Review SummaryVerdict: REQUEST CHANGES (sticky comment only) Findings Overview
FindingsSecurity / Performance
Correctness
|
kelos-bot
Bot
force-pushed
the
agent/session-markdown-tables
branch
from
July 17, 2026 13:00
a946863 to
3634258
Compare
kelos-bot
Bot
force-pushed
the
agent/session-markdown-tables
branch
from
July 17, 2026 13:21
3634258 to
812aa10
Compare
gjkim42
enabled auto-merge
July 17, 2026 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds GFM-style pipe table support to the Session web chat Markdown renderer.
The renderer recognizes valid header and delimiter rows, applies optional column alignment, preserves inline Markdown inside cells, and handles escaped pipes and pipes inside code spans. Tables continue to use safe DOM construction rather than HTML injection, and wide tables scroll horizontally on narrow screens.
This also adds behavioral and safety coverage for aligned tables, optional outer pipes, uneven row widths, malformed table input, inline links and code, and raw HTML escaping.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Validation:
make verifyenv -u CODEX_HOME -u CODEX_AUTH_JSON make testgit diff --checkThe Codex variables are unset for the unit suite because the agent environment injects them globally, while entrypoint isolation tests expect them to be absent.
Does this PR introduce a user-facing change?
Summary by cubic
Add GFM-style pipe table support to the Session web chat Markdown renderer. Tables render safely with alignment, horizontal scrolling, and a 10k-cell cap.
Written for commit 812aa10. Summary will update on new commits.