Add regression test for #5074 (NPE on futures orders without cummulativeQuoteQty)#5327
Open
Baqirrizvidev wants to merge 1 commit into
Open
Add regression test for #5074 (NPE on futures orders without cummulativeQuoteQty)#5327Baqirrizvidev wants to merge 1 commit into
Baqirrizvidev wants to merge 1 commit into
Conversation
…eQty USDT-M futures order responses have no cummulativeQuoteQty field, which used to cause an NPE in BinanceAdapters.adaptOrder (knowm#5074). The null guard added in knowm#5075 fixed it; this locks the behaviour in with a test so it cannot regress. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #5074
USDT-M futures order responses carry no
cummulativeQuoteQtyfield, which used to cause an NPE when adapting the order. The null guard added in #5075 (BinanceAdapters.java—order.cumulativeQuoteQty != nullbefore thedivide) already fixes the reported crash, but the issue was left open and nothing prevents a regression.This PR adds a fixture for a filled USDT-M futures MARKET order without
cummulativeQuoteQtyand a test assertingBinanceAdapters.adaptOrder(order, true)adapts it without throwing.With this in, #5074 can be closed as fixed by #5075.
mvn -pl xchange-binance -am test -Dtest=BinanceAdaptersTestpasses (4/4).🤖 Generated with Claude Code