Skip to content

Update docker-compose.mysql.yml #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tontonjo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update docker-compose.mysql.yml #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.mysql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ services:
- DB_DATABASE=koel
volumes:
- music:/music
- image_storage:/var/www/html/storage/app/public/images
- image_storage:/var/www/html/public/storage/images

@coderabbitai coderabbitai Bot Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Restore the image_storage mount target to Koel’s internal storage path.

This change points the volume to /var/www/html/public/storage/images, but the image and init flow persist/read images at /var/www/html/storage/app/public/images. Mounting the wrong target breaks the storage contract and can cause unreadable/unwritable image storage or lost persistence behavior after init/migrations.

Suggested fix 
-      - image_storage:/var/www/html/public/storage/images
+      - image_storage:/var/www/html/storage/app/public/images

Based on learnings: Dockerfile creates/declares /var/www/html/storage/app/public/images as the image-storage volume path, and CHANGELOG documents this exact compose mount target for upgrades.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- image_storage:/var/www/html/public/storage/images
- image_storage:/var/www/html/storage/app/public/images
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docker-compose.mysql.yml` at line 16, The compose mount uses the wrong target
path causing Koel to read/write images in the wrong place; update the volume
mapping for image_storage so it mounts to Koel’s internal storage path
/var/www/html/storage/app/public/images (replace the current
/var/www/html/public/storage/images target), ensuring the image_storage volume
name remains unchanged and the service that declares this volume continues to
reference image_storage.

- search_index:/var/www/html/storage/search-indexes
- ./sql:/docker-entrypoint-initdb.d

Expand Down