Skip to content

ci: build release images on tag push only#226

Merged
phanan merged 1 commit into
masterfrom
ci/remove-release-workflow-dispatch
Jul 1, 2026
Merged

ci: build release images on tag push only#226
phanan merged 1 commit into
masterfrom
ci/remove-release-workflow-dispatch

Conversation

@phanan

@phanan phanan commented Jul 1, 2026

Copy link
Copy Markdown
Member

What

Remove the workflow_dispatch trigger (and its koel_version input) from the release workflow, so release images are built only on a pushed v* tag.

Why

The manual dispatch path built and pushed images against an arbitrary koel_version without going through the ./release script — meaning it never bumped ARG KOEL_VERSION_REF in the Dockerfile / the goss.yaml version, never tagged the repo vX.Y.Z, and never moved latest. The result was an image build with no corresponding repo release: source stuck on an old version, no tag, stale latest.

Making tag-push the only trigger forces every release through ./release vX.Y.Z, which performs the version bump + tag + latest move and then triggers the build via the tag push. One path, always complete.

Changes

  • Drop workflow_dispatch and the koel_version input from on:.
  • Simplify the "Resolve version" step to read $GITHUB_REF_NAME directly (the env-var indirection existed only to guard the dispatch input against template injection; with tag-push only, the ref is trusted).

Summary by CodeRabbit

  • Chores
    • Release automation now runs only when a version tag is pushed.
    • Removed the option to start the release process manually with a version input.
    • Release version values are now taken directly from the tag name, simplifying how releases are identified.

Remove the workflow_dispatch trigger so the release image can only be
built via a pushed v* tag (i.e. through ./release). Manual dispatch
built images without bumping the Dockerfile/goss version or tagging the
repo, producing incomplete releases.
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0dffbb31-a390-4986-aab2-68e1a77f50cf

📥 Commits

Reviewing files that changed from the base of the PR and between 9cc04f4 and 8af5540.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow's trigger is simplified to only fire on tag pushes matching v*, removing the manual workflow_dispatch option and its koel_version input. The version resolution step now derives the version directly from GITHUB_REF_NAME instead of an intermediate KOEL_VERSION fallback.

Changes

Release Workflow Simplification

Layer / File(s) Summary
Trigger and version resolution
.github/workflows/release.yml
Removes the workflow_dispatch trigger and koel_version input, and simplifies the "Resolve version" step to set REF="$GITHUB_REF_NAME" directly.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • koel/docker#222: Introduced the workflow_dispatch/KOEL_VERSION-based version resolution that this PR removes and reverts back to GITHUB_REF_NAME.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the workflow change to build release images only on tag pushes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/remove-release-workflow-dispatch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@phanan phanan merged commit d82591e into master Jul 1, 2026
3 checks passed
@phanan phanan deleted the ci/remove-release-workflow-dispatch branch July 1, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant