ci: build release images on tag push only#226
Merged
Conversation
Remove the workflow_dispatch trigger so the release image can only be built via a pushed v* tag (i.e. through ./release). Manual dispatch built images without bumping the Dockerfile/goss version or tagging the repo, producing incomplete releases.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow's trigger is simplified to only fire on tag pushes matching ChangesRelease Workflow Simplification
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
workflow_dispatchtrigger (and itskoel_versioninput) from the release workflow, so release images are built only on a pushedv*tag.Why
The manual dispatch path built and pushed images against an arbitrary
koel_versionwithout going through the./releasescript — meaning it never bumpedARG KOEL_VERSION_REFin theDockerfile/ thegoss.yamlversion, never tagged the repovX.Y.Z, and never movedlatest. The result was an image build with no corresponding repo release: source stuck on an old version, no tag, stalelatest.Making tag-push the only trigger forces every release through
./release vX.Y.Z, which performs the version bump + tag +latestmove and then triggers the build via the tag push. One path, always complete.Changes
workflow_dispatchand thekoel_versioninput fromon:.$GITHUB_REF_NAMEdirectly (the env-var indirection existed only to guard the dispatch input against template injection; with tag-push only, the ref is trusted).Summary by CodeRabbit