Skip to content

fix: drop the double slash from the boolean flags FAQ link - #1053

Merged
JonJagger merged 1 commit into
mainfrom
fix-double-slash-in-faq-link
Jul 29, 2026
Merged

fix: drop the double slash from the boolean flags FAQ link#1053
JonJagger merged 1 commit into
mainfrom
fix-double-slash-in-faq-link

Conversation

@JonJagger

@JonJagger JonJagger commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

BooleanArgsMessageLink pointed at https://docs.kosli.com//faq/#boolean-flags.
The doubled slash is the only such link in the repo, and while the site does
serve it, a URL a user is being told to visit should not look malformed.

The golden it is asserted against carried the same typo, so the test moved
with it.

Checklist

  BooleanArgsMessageLink pointed at https://docs.kosli.com//faq/#boolean-flags.
  The doubled slash is the only such link in the repo, and while the site does
  serve it, a URL a user is being told to visit should not look malformed.

  The golden it is asserted against carried the same typo, so the test moved
  with it.
@claude

claude Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Claude finished @JonJagger's task in 43s —— View job


PR Review: drop the double slash from the boolean flags FAQ link

  • Gather context (diff, surrounding code)
  • Static checks (go build ./...)
  • Verify no other malformed links remain
  • Review the change

Verdict: ✅ Looks good — approve-worthy

This is a small, well-scoped fix and the reasoning in the PR description is sound.

What I checked:

  1. The change is correct. docs.kosli.com//faq/docs.kosli.com/faq/ in cmd/kosli/cli_utils.go:778, and the golden in cmd/kosli/attestGeneric_test.go:74 was updated to match.

  2. It aligns with the existing convention. The single-slash form is already what the rest of the repo uses — the flag-description link generated elsewhere (surfaced in cmd/kosli/multiHost_test.go:228 and internal/docgen/mintlify_test.go:194-195) already reads https://docs.kosli.com/faq/#boolean-flags. So this change makes the outlier consistent rather than introducing a new style.

  3. No stragglers left. A repo-wide search for docs.kosli.com// returns no matches, confirming the PR's claim that this was the only doubled-slash link.

  4. Build passes. go build ./... compiles cleanly.

  5. Test coverage is present. The behaviour is exercised by TestAttestGenericCmd ("links to the boolean flags FAQ when a stray true|false argument remains"), and the golden moved with the fix so the assertion stays meaningful.

Minor observations (non-blocking, not introduced by this PR):

  • BooleanArgsMessageLink (cli_utils.go:776-783) has a stray blank line before the closing brace and an else after a return that gofmt/lint might otherwise flag — but these are pre-existing and out of scope for a one-line link fix.

Nice, tidy change with a clear rationale. 👍
• Branch: fix-double-slash-in-faq-link

@JonJagger
JonJagger enabled auto-merge (squash) July 29, 2026 09:17
@JonJagger
JonJagger merged commit bd85196 into main Jul 29, 2026
20 checks passed
@JonJagger
JonJagger deleted the fix-double-slash-in-faq-link branch July 29, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants