docs: update CLI and helm reference for v2.35.0 - #343
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
|
Claude finished @github-actions[bot]'s task in 2m 15s —— View job Reviewing PR #343 — CLI & Helm reference update for v2.35.0
Review summaryThis is an automated update of CLI and Helm reference documentation for v2.35.0. The changes fall into three categories:
FindingsNo critical issues found. Improvements
Suggestions
Checks performed
Overall: This PR looks good to merge. It's a clean automated refresh with proper cleanup of the removed approval commands. |
ToreMerkely
approved these changes
Jul 28, 2026
4 tasks
ToreMerkely
added a commit
that referenced
this pull request
Jul 28, 2026
Approvals are being retired (kosli-dev/server#5125). CLI v2.35.0 removed the approval commands and server kosli-dev/server#6309 removed the approval API, which is now in prod. The `update-cli-docs` workflow already deleted the five generated `client_reference` pages and their nav entries in #343. This PR covers everything that automation cannot do. ## Changes - **Redirects** — `config/redirects.json` gets the five deleted `client_reference/kosli_*approval*` URLs pointing at `/client_reference/overview`. The workflow deletes pages but never touches redirects, so those URLs were 404ing for bookmarks and search hits. - **`tutorials/cli_and_http_proxy.md`** — removed the `kosli request approval` example; the page still shows two proxy examples. - **`integrations/kosli_actions.md`** — the documented custom-webhook payload now matches `MessageProvider._webhook_base_payload`: dropped the `approvals` array, and the `deployments` array with it (the builder emits neither, and the `deployments` collection was dropped long ago — stale independently of #5125). - **`administration/managing_users/roles_in_kosli.md`** — removed the permission-matrix row and the four per-role bullets. - **`understand_kosli/glossary.md` / `controls.md`** — `approval` was never a built-in attestation type; the built-ins are `generic`, `junit`, `snyk`, `pull_request`, `jira`, `sonar`. - **Changelog** — a v2.35.0 CLI entry with the breaking removal, plus a Platform entry for the API removal. - **`kosli get trail` live example** — repointed from the pinned March 2024 trail (which contains `artifact_approval_reported` events) to `e4757683b74df7033c95aa544a7824b395c2f8bb` (July 2026, 16 events, no approvals), and regenerated the page. Since the page is generated, pinning a newer trail is the only way to stop the approval events reappearing on every CLI release. - **Dead live-docs plumbing** — removed the `kosli report approval` modifier entry and moved the two tests that used it as their fixture onto commands that still exist. ## Test plan - [x] `pytest tests/` — 22 passed - [x] `python scripts/test_update_cli_nav.py` — PASS - [x] `mint broken-links` — no new breakages (the one hit, `/getting_started/service-accounts` in `tutorials/working_with_controls.mdx`, is pre-existing and untouched here) - [x] `rg -in approval` sweep — only concept/PR-approval prose and the `has-approval` policy name remain Live-docs test fixtures were deliberately left unrefreshed: regenerating them rewrites all five files with fresh live data and the suite passes without it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated update of CLI and Helm reference documentation for release
v2.35.0.