feat(helm): add Helm OCI chart publishing#6480
Conversation
|
Welcome @rektide! |
|
Hi @rektide. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
We don't have access to google cloud |
|
It's not that we're opposed to OCI support; the problem is that it's an Kubernetes+CNCF ecosystem is driven buy some opinionated individuals and we simply don't have the infrastructure for for that. Helm isn't an official distribution mechanism, which is why it hasn't gained traction. |
|
It would be awesome if you DID publish the OCI artifact. We have a ton of semi-airgapped environments, whose only access to the outside world are through things like Nexus Proxies etc. If you did something like this https://github.com/cloudnative-pg/charts/blob/main/.github/workflows/release-publish.yml#L61 and just published the chart to the Github Container Registry, we could pull it through the existing github docker proxies. Currently we have to maintain a specific copy of this helm chart's helm proxy. its not world ending or anything, its just another thing to maintain. |
| - | | ||
| set -o pipefail | ||
|
|
||
| if [[ "$_PULL_BASE_REF" =~ ^v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?$ ]]; then |
There was a problem hiding this comment.
the tag for helm chart is not vX.Y.Z, it's more like external-dns-helm-chart-1.21.1
|
@ivankatliarchuk It seems that there is a path, nowadays. See https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/README.md#helm-chart-promotion It's already used for other sigs projects: |
What does it do ?
This is yet another draft attempt to try to add Helm OCI chart publishing, resolving #4630. This is presented for discussion primarily.
Motivation
Helm users are increasingly used to managing and consuming Charts via OCI, which offers a more standardized common way to access repositories than the bespoke Helm repositories of yore. There are however quite a variety of different implementations across projects. This draft is intended to offer a viable, for consideration of ideas, that distills out a solution based on what existing projects are doing, to help get thoughts flowing about what might be the right way to go. This draft is presented for discussion.
Note
There is also kubernetes-sigs/metrics-server#1817, which is another Helm OCI Chart I've tried drafting. See kubernetes-sigs/metrics-server#1527 for more discussion in general.
More