Skip to content

fix: make TXT name mapper zone-aware to handle dots in hostname#6494

Open
karthikk022 wants to merge 1 commit into
kubernetes-sigs:masterfrom
karthikk022:fix/txt-name-mapper-zone-aware
Open

fix: make TXT name mapper zone-aware to handle dots in hostname#6494
karthikk022 wants to merge 1 commit into
kubernetes-sigs:masterfrom
karthikk022:fix/txt-name-mapper-zone-aware

Conversation

@karthikk022

@karthikk022 karthikk022 commented Jun 13, 2026

Copy link
Copy Markdown

No description provided.

@karthikk022
fix: make TXT name mapper zone-aware to handle dots in hostname
ce948b4 
Fixes kubernetes-sigs#5151: external-dns creates malformed RR when name contains dot

The ToTXTName function was splitting the DNS name at the first dot,
which broke hostnames containing dots (e.g., name-192.168.0.1.example.com
was split as 'name-192' and '168.0.1.example.com' instead of
'name-192.168.0.1' and 'example.com').

Changes:
- Added zones field to AffixNameMapper for zone-aware splitting
- Added NewAffixNameMapperWithZones constructor accepting zone list
- Added findZone method to match DNS name against configured zones
- Updated ToTXTName to split at zone boundary instead of first dot
- Updated TXTRegistry to pass zones from provider's domain filter to mapper
- Zones are sorted by specificity (longest first) for correct matching

This fix maintains backward compatibility - if no zones are configured,
falls back to the original first-dot splitting behavior.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 13, 2026
@k8s-ci-robot

k8s-ci-robot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Invalid commit message issues detected

Invalid commit messages

Keywords which can automatically close issues and hashtag(#) mentions are not allowed.

  • ce948b4 fix: make TXT name mapper zone-aware to handle dots in hostname

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot

k8s-ci-robot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ivankatliarchuk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the registry Issues or PRs related to a registry label Jun 13, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 13, 2026

Copy link
Copy Markdown

CLA Not Signed

@k8s-ci-robot

k8s-ci-robot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Welcome @karthikk022!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

k8s-ci-robot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Hi @karthikk022. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivankatliarchuk ivankatliarchuk Awaiting requested review from ivankatliarchuk

@vflaux vflaux Awaiting requested review from vflaux

Assignees

No one assigned

Labels

cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. registry Issues or PRs related to a registry size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karthikk022 @k8s-ci-robot