feat(source/template): add fqdn-target-template to pod/service/node and consolidate duplicate template helpers#6497
Open
ivankatliarchuk wants to merge 7 commits into
Conversation
…nd consolidate duplicate template helpers Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…nd consolidate duplicate template helpers Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
Coverage Report for CI Build 27505670507Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.2%) to 81.196%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions196 previously-covered lines in 8 files lost coverage.
Coverage Stats
💛 - Coveralls |
…nd consolidate duplicate template helpers Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
…nd consolidate duplicate template helpers Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
…nd consolidate duplicate template helpers Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
…sources-and-engine-helpers
…nd consolidate duplicate template helpers Signed-off-by: ivan katliarchuk <ivan.katliarchuk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do ?
Motivation
It could be refactored further, let's say this is going to be to-path refactor. And this is a first step.
More