Don't set safe.dir=* in main app#993
Open
thockin wants to merge 4 commits into
Open
Conversation
kubernetes-prow
Bot
added
the
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
approved
thockin
force-pushed
the
dont_use_safe.dir_star
branch
from
aacde09 to
036ea17
Compare
Instead, set it in tests. This requires a new flag `--add-git-config` which is like `--git-config` but uses repeated calls to the flag instead of a comma-separated value.
thockin
force-pushed
the
dont_use_safe.dir_star
branch
from
036ea17 to
742869b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #849
Instead, set it in tests. This requires a new flag
--add-git-configwhich is like--git-configbut uses repeated calls to the flag instead of a comma-separated value.Also puts
/usr/lib/git-core/git-sh-i18n--envsubstback into the image since it shows up in error logs.