fix(LINK-4383): mount checkout at host path so container git can authenticate#273
Merged
Conversation
jeremydubreil
force-pushed
the
remove-app-src
branch
from
bf38c41 to
e329336
Compare
jeremydubreil
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds code to pass more information to the
docker runcommand to make sure that thegitinvocations happening during thesca scanare working as expected.Tested that the new code on WebGoat which was previously working to make sure there is no regressions: PR comment created here: https://github.com/lacework-dev/WebGoat/pull/180#issuecomment-4781331905
Test on services that was not fully working before because the default branch could not be correctly retrieved before: #273 (comment)
Before these changes, we were getting the following error on services: https://github.com/lacework/services/actions/runs/28084648774/job/83147543749#step:3:172