Skip to content

only require library component if it is built#643

Open
buechlerm wants to merge 2 commits into
mainfrom
buechler/interface_fix
Open

only require library component if it is built#643
buechlerm wants to merge 2 commits into
mainfrom
buechler/interface_fix

Conversation

@buechlerm

Copy link
Copy Markdown
Collaborator

This changes cmake so that when the archive library isn't built it isn't required by default either. Please review vigorously as I'm not really a cmake expert.

PR Summary

When closure isn't built an archive file isn't created. This makes it so that users don't have a default requirement for an archive that doesn't exist. There is a work around on their part, if we don't like my solution here.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • [x ] LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@buechlerm buechlerm requested review from dholladay00 and rbberger July 8, 2026 14:33

@rbberger rbberger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is user-facing, we should probably have a changelog entry that we can point to in a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants