Fix/check 02 allow old syntax 4 select option#1122
Open
alezhu wants to merge 12 commits into
Open
Conversation
…on. Also fix patterns to allow multiple spaces around option
…abap Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
…b.com:alezhu/abapOpenChecks into fix/check_02_allow_old_syntax_4_select_option
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
…testclasses.abap Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
…b.com:alezhu/abapOpenChecks into fix/check_02_allow_old_syntax_4_select_option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IF we have code with default value for select-option like this:
SELECT-OPTIONS s_date FOR d DEFAULT '20231207' SIGN I OPTION GE MODIF ID mr.the check is raising error 'Use new operator' because we use 'GE' instead of '>='.
But in select-options we have to use only 'old' operators.
This PR fix it.
Additionally, the is_old method continues searching for a pattern in the statement even if it has already found one. Fixed that too.
Also use regular expression to find patterns for include and exclude, because CP has problem. For example for
iv_statement CP '* EQ TYPE *:DATA eq TYPE C.- validDATA eq TYPE C.- invalid (2 spaces before and after TYPE)