-
Notifications
You must be signed in to change notification settings - Fork 4
feat: Add C bindings for Redis Big Segments store #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to note that the error massages may contain things like query parameters and you may want to consider sanitizing them?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| /** @file redis_big_segment_store.h | ||
| * @brief LaunchDarkly Server-side Redis Big Segments Store C Binding. | ||
| */ | ||
| // NOLINTBEGIN modernize-use-using | ||
| #pragma once | ||
|
|
||
| #include <launchdarkly/bindings/c/export.h> | ||
|
|
||
| #include <stdbool.h> | ||
|
|
||
| #ifdef __cplusplus | ||
| extern "C" { | ||
| // only need to export C interface if | ||
| // used by C++ source code | ||
| #endif | ||
|
|
||
| /** | ||
| * @brief LDServerBigSegmentsRedisStore is a Big Segments persistent store for | ||
| * the Server-Side SDK backed by Redis. It is meant to be passed to the SDK | ||
| * via the Big Segments config builder. | ||
| * | ||
| * Call @ref LDServerBigSegmentsRedisStore_New to obtain a new instance. This | ||
| * instance is passed into the SDK's Big Segments configuration. | ||
| * | ||
| * Example: | ||
| * @code | ||
| * // Stack allocate the result struct, which will hold the result pointer or | ||
| * // an error message. | ||
| * struct LDServerBigSegmentsRedisResult result; | ||
| * | ||
| * // Create the Redis Big Segment store, passing in arguments for the URI, | ||
| * // prefix, and pointer to the result. | ||
| * if (!LDServerBigSegmentsRedisStore_New("redis://localhost:6379", | ||
| * "testprefix", &result)) { | ||
| * // On failure, you may print the error message (result.error_message), | ||
| * // then exit or return. | ||
| * } | ||
| * | ||
| * // Create the Big Segments builder, taking ownership of the store pointer. | ||
| * LDServerBigSegmentsBuilder bs_builder = LDServerBigSegmentsBuilder_New( | ||
| * (LDServerBigSegmentStorePtr)result.store); | ||
| * | ||
| * // Attach the Big Segments builder to the SDK config. | ||
| * LDServerConfigBuilder cfg_builder = LDServerConfigBuilder_New("sdk-123"); | ||
| * LDServerConfigBuilder_BigSegments(cfg_builder, bs_builder); | ||
| * @endcode | ||
| * | ||
| * This implementation is backed by <a | ||
| * href="https://github.com/sewenew/redis-plus-plus">Redis++</a>, a C++ wrapper | ||
| * for the <a href="https://github.com/redis/hiredis">hiredis</a> library. | ||
| */ | ||
| typedef struct _LDServerBigSegmentsRedisStore* LDServerBigSegmentsRedisStore; | ||
|
|
||
| /* Defines the size of the error message buffer in | ||
| * LDServerBigSegmentsRedisResult. | ||
| */ | ||
| #ifndef LDSERVER_BIGSEGMENTS_REDISSTORE_ERROR_MESSAGE_SIZE | ||
| #define LDSERVER_BIGSEGMENTS_REDISSTORE_ERROR_MESSAGE_SIZE 256 | ||
| #endif | ||
|
|
||
| /** | ||
| * @brief Stores the result of calling @ref LDServerBigSegmentsRedisStore_New. | ||
| * | ||
| * On successful creation, store will contain a pointer which may be passed | ||
| * into the LaunchDarkly SDK's Big Segments configuration. | ||
| * | ||
| * On failure, error_message contains a NULL-terminated string describing the | ||
| * error. | ||
| * | ||
| * The message may be truncated if it was originally longer than | ||
| * error_message's buffer size. | ||
| * | ||
| * The message originates from the underlying Redis client and may echo back | ||
| * portions of the URI, including query parameters. Callers that surface this | ||
| * message (logs, telemetry, user-facing errors) may want to sanitize it | ||
| * accordingly. | ||
| */ | ||
| struct LDServerBigSegmentsRedisResult { | ||
| LDServerBigSegmentsRedisStore store; | ||
| char error_message[LDSERVER_BIGSEGMENTS_REDISSTORE_ERROR_MESSAGE_SIZE]; | ||
| }; | ||
|
|
||
| /** | ||
| * @brief Creates a new Redis Big Segment store suitable for usage in the SDK's | ||
| * Big Segments configuration. | ||
| * | ||
| * In this system, the SDK will query Redis for Big Segments membership | ||
| * as required, with an in-memory cache to reduce the number of queries. | ||
| * | ||
| * Data is never written back to Redis by the SDK; the LaunchDarkly Relay | ||
| * Proxy populates the store. | ||
| * | ||
| * @param uri Redis URI string. Must not be NULL or empty string. | ||
| * | ||
| * @param prefix Prefix to use when reading SDK data from Redis. This allows | ||
| * multiple SDK environments to coexist in the same database, or for the SDK's | ||
| * data to coexist with other unrelated data. Must not be NULL. | ||
| * | ||
| * @param out_result Pointer to struct where the store pointer or an error | ||
| * message should be stored. | ||
| * | ||
| * @return True if the store was created successfully; out_result->store | ||
| * will contain the pointer. The caller must either free the pointer with | ||
| * @ref LDServerBigSegmentsRedisStore_Free, OR pass it into the SDK's Big | ||
| * Segments configuration which will take ownership (in which case do not | ||
| * call @ref LDServerBigSegmentsRedisStore_Free.) | ||
| */ | ||
| LD_EXPORT(bool) | ||
| LDServerBigSegmentsRedisStore_New( | ||
| char const* uri, | ||
| char const* prefix, | ||
| struct LDServerBigSegmentsRedisResult* out_result); | ||
|
|
||
| /** | ||
| * @brief Frees a Redis Big Segment store pointer. Only necessary to call if | ||
| * not passing ownership to the SDK's Big Segments configuration. | ||
| */ | ||
| LD_EXPORT(void) | ||
| LDServerBigSegmentsRedisStore_Free(LDServerBigSegmentsRedisStore store); | ||
|
|
||
| #ifdef __cplusplus | ||
| } | ||
| #endif | ||
|
|
||
| // NOLINTEND modernize-use-using |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| #include <launchdarkly/server_side/bindings/c/integrations/redis/redis_big_segment_store.h> | ||
|
Check failure on line 1 in libs/server-sdk-redis-source/src/bindings/redis/redis_big_segment_store.cpp
|
||
|
|
||
| #include <launchdarkly/server_side/integrations/redis/redis_big_segment_store.hpp> | ||
|
|
||
| #include <launchdarkly/detail/c_binding_helpers.hpp> | ||
|
|
||
| #include <cstring> | ||
|
|
||
| using namespace launchdarkly::server_side::integrations; | ||
|
|
||
| LD_EXPORT(bool) | ||
| LDServerBigSegmentsRedisStore_New(char const* uri, | ||
|
Check warning on line 12 in libs/server-sdk-redis-source/src/bindings/redis/redis_big_segment_store.cpp
|
||
| char const* prefix, | ||
| LDServerBigSegmentsRedisResult* out_result) { | ||
| LD_ASSERT_NOT_NULL(uri); | ||
| LD_ASSERT_NOT_NULL(prefix); | ||
| LD_ASSERT_NOT_NULL(out_result); | ||
|
|
||
| // Explicitely zero out the exception_msg buffer in case the exception is | ||
| // shorter than the buffer. | ||
| memset(out_result->error_message, 0, | ||
| sizeof(LDServerBigSegmentsRedisResult::error_message)); | ||
|
|
||
| // Ensure the store pointer isn't garbage. | ||
| out_result->store = nullptr; | ||
|
|
||
| auto maybe_store = RedisBigSegmentStore::Create(uri, prefix); | ||
| if (!maybe_store) { | ||
| // Avoid heap allocating another string to pass back to the caller; | ||
| // instead, we copy into the buffer and ensure a terminator is present. | ||
| // This does mean the message may be truncated. | ||
|
|
||
| std::size_t const len = maybe_store.error().copy( | ||
| out_result->error_message, sizeof(out_result->error_message) - 1); | ||
| out_result->error_message[len] = '\0'; | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| // The pointer is no longer managed and must either be freed by the caller, | ||
| // or passed into the SDK which will take ownership. | ||
| out_result->store = | ||
| reinterpret_cast<LDServerBigSegmentsRedisStore>(maybe_store->release()); | ||
|
|
||
| return true; | ||
| } | ||
|
|
||
| LD_EXPORT(void) | ||
| LDServerBigSegmentsRedisStore_Free(LDServerBigSegmentsRedisStore store) { | ||
| delete reinterpret_cast<RedisBigSegmentStore*>(store); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need stdbool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done