Skip to content

chore: aligning vue composables to trigger eval events#1804

Open
joker23 wants to merge 1 commit into
mainfrom
skz/SDK-2675/migrate-vue-sdk-variation-core-context-fix
Open

chore: aligning vue composables to trigger eval events#1804
joker23 wants to merge 1 commit into
mainfrom
skz/SDK-2675/migrate-vue-sdk-variation-core-context-fix

Conversation

@joker23

@joker23 joker23 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Changes when and how often flag evaluations run (including possible double eval on identify), which can affect analytics impressions and UI timing for all Vue variation composables.

Overview
useVariationCore no longer watches provider context / initializedState or batches updates through a flagChanged counter. Flag refs now re-evaluate from two explicit client hooks: change:<key> and onContextChange (settled start() and completed identify()), with cleanup on scope dispose.

Tests and makeMockClient were updated to assert subscription lifecycle (contextSubscriberCount), init-complete/failed paths via context notification (including SDK-2640 single eval on failure), and the new eval semantics: one eval when only the flag or only context changes, two when both fire on the same identify (documented as accepted React-parity cost, SDK-2194).

Reviewed by Cursor Bugbot for commit 5856f64. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26360 bytes
Compressed size limit: 29000
Uncompressed size: 129188 bytes

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179691 bytes
Compressed size limit: 200000
Uncompressed size: 831704 bytes

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 39108 bytes
Compressed size limit: 39300
Uncompressed size: 213642 bytes

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 32077 bytes
Compressed size limit: 34000
Uncompressed size: 114525 bytes

@joker23

joker23 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

cursor[bot]

This comment was marked as resolved.

@joker23
joker23 marked this pull request as ready for review July 14, 2026 22:33
@joker23
joker23 requested a review from a team as a code owner July 14, 2026 22:33
devin-ai-integration[bot]

This comment was marked as resolved.

@joker23
joker23 force-pushed the skz/SDK-2675/migrate-vue-sdk-variation-core-context-fix branch from 1f6a8b1 to 5856f64 Compare July 23, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant