chore: aligning vue composables to trigger eval events#1804
Open
joker23 wants to merge 1 commit into
Open
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
Author
|
@cursor review |
joker23
marked this pull request as ready for review
July 14, 2026 22:33
joker23
force-pushed
the
skz/SDK-2675/migrate-vue-sdk-variation-core-context-fix
branch
from
July 23, 2026 17:55
1f6a8b1 to
5856f64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes when and how often flag evaluations run (including possible double eval on identify), which can affect analytics impressions and UI timing for all Vue variation composables.
Overview
useVariationCoreno longer watches providercontext/initializedStateor batches updates through aflagChangedcounter. Flag refs now re-evaluate from two explicit client hooks:change:<key>andonContextChange(settledstart()and completedidentify()), with cleanup on scope dispose.Tests and
makeMockClientwere updated to assert subscription lifecycle (contextSubscriberCount), init-complete/failed paths via context notification (including SDK-2640 single eval on failure), and the new eval semantics: one eval when only the flag or only context changes, two when both fire on the same identify (documented as accepted React-parity cost, SDK-2194).Reviewed by Cursor Bugbot for commit 5856f64. Bugbot is set up for automated code reviews on this repo. Configure here.